Attempt to add proguard configuration to aar

[emartynov]

This is called "attempt" since I was not able to build it on Mac.

Because I was not able to build binary after hour installing ndk, playing with tools (gradle, AGP) update and playing with bash file trying to disable old platform types that are not supported by latest NDK.

Please review and comment.

[developernotes]

Hi @emartynov

Thank you for your interest in SQLCipher for Android. Is there a reason for the nested defaultConfig within your diff?

[emartynov]

Hey, this looks like indeed a mistake. If I would just able to build the library to check. I will try on side project library and update gradle file here.

[developernotes]

Hi @emartynov

Great, thanks. Please feel free to update the pull request once you've had a chance to confirm.

[zsavely]

I think this line is keeping too much. This should be reduced to specific classes/methods/variables.
The reason for supplying Proguard rules in a library is for the clients (developers) to not waste time on examining the library's internals. However, this rule is useless as every developer can come up with such a solution for every library.

[brodycj]

@emartynov @developernotes I was wondering if there are any plans to develop this further?

From a quick search I found something that looks interesting: https://developer.android.com/studio/build/shrink-code

[developernotes]

Hi @brodybits, @emartynov

Yes, we would certainly be interested in including something like this within a future release of the software. We will need to evaluation what options to configure within the ProGuard file to prevent any unnecessary removal during compilation time.

[AlexTrotsenko]

@developernotes As far as I see, everyone still have to add following rules manually according to the README, right?

-keep,includedescriptorclasses class net.sqlcipher.** { *; }
-keep,includedescriptorclasses interface net.sqlcipher.** { *; }

If it's the case - how about adding this two lines into the proguard rules to the project sources?
Then it can referenced via consumerProguardFiles in the way as it's suggested in the official documentation?

Could be a good starting point or ?