Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken Parcellable implementation in ModalContainer #245

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

rjrjr
Copy link
Contributor

@rjrjr rjrjr commented Apr 1, 2019

Don't know how I merged it this way. :( square/workflow-kotlin#779 tracks the need to get tests
around this, which will not be any fun at all.

Closes #244.

Don't know how I merged it this way. :( #246 tracks the need to get tests
around this, which will not be any fun at all.

Closes #244.
@rjrjr rjrjr force-pushed the ray/fix-sample-snapshot-code branch from 5ffe778 to 8b15088 Compare April 1, 2019 20:37
Copy link
Collaborator

@zach-klippenstein zach-klippenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a unit test for this.

Copy link
Collaborator

@zach-klippenstein zach-klippenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize you were tracking the unit test work, sorry.

@rjrjr rjrjr merged commit 6f65bbd into master Apr 1, 2019
@rjrjr rjrjr deleted the ray/fix-sample-snapshot-code branch April 1, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants