Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename WorkflowContext.compose to composeChild. #274

Merged
merged 1 commit into from
Apr 13, 2019
Merged

Rename WorkflowContext.compose to composeChild. #274

merged 1 commit into from
Apr 13, 2019

Conversation

zach-klippenstein
Copy link
Collaborator

Closes #267.

@zach-klippenstein zach-klippenstein added this to the v0.13.0 milestone Apr 12, 2019
@rjrjr
Copy link
Contributor

rjrjr commented Apr 12, 2019

I take it you're going to follow up and rename both methods to render / renderChild?

@zach-klippenstein zach-klippenstein modified the milestones: v0.13.0, v0.14.0 Apr 13, 2019
@zach-klippenstein
Copy link
Collaborator Author

I take it you're going to follow up and rename both methods to render / renderChild?

Yes

@zach-klippenstein zach-klippenstein merged commit ee8e7a8 into master Apr 13, 2019
@zach-klippenstein zach-klippenstein deleted the zachklipp/composeChild branch April 13, 2019 00:15
@zach-klippenstein zach-klippenstein added the kotlin Affects the Kotlin library. label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjrjr rjrjr rjrjr approved these changes

@timdonnelly timdonnelly Awaiting requested review from timdonnelly

@davidapgar davidapgar Awaiting requested review from davidapgar

Assignees
No one assigned
Labels
kotlin Affects the Kotlin library.
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

Rename WorkflowContext.compose/render method to composeChild/renderChild
2 participants
@zach-klippenstein @rjrjr