Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not copy hostname to socket options servername (server name indication) #697

Closed
urbanhusky opened this issue Jul 25, 2022 · 2 comments
Closed
Labels

Comments

@urbanhusky
Copy link

RFC 6066 specifies that the Server Name Indication must not be an IP address.
Unfortunately amqplib blindly copies the hostname from the url to this field, which causes DEP0123 warnings when connecting to an IP address.
Besides, the hostname is not necessarily identical to the server name indication, so it should be configurable e.g. via the socketOptions provided to connect(…)

Source:
https://github.com/amqp-node/amqplib/blob/main/lib/connect.js#L109
https://datatracker.ietf.org/doc/html/rfc6066#section-3

@cressie176
Copy link
Collaborator

Hi @urbanhusky,
Thanks for reporting. I agree.

@cressie176 cressie176 added the bug label Jul 26, 2022
@cressie176
Copy link
Collaborator

Published as amqplib@0.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants