Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with github/linguist #155

Open
1 of 4 tasks
smola opened this issue Aug 27, 2018 · 7 comments
Open
1 of 4 tasks

Sync with github/linguist #155

smola opened this issue Aug 27, 2018 · 7 comments
Assignees
Labels
enhancement ☂️ umbrella issue

Comments

@smola
Copy link
Contributor

smola commented Aug 27, 2018

We synchronized with github/linguist in November 2017, an update is long overdue ;)


Latest enry v1.6.7 from Oct 24, 2018 is based on Linguist v5.2.0 commit 4cd558 from Sep 17, 2017.

This is an ☂️ issue with the goal to make enry use of at least at least Linguist v7.1.3 from Dec 12, 2018:

@smola
Copy link
Contributor Author

smola commented Aug 27, 2018

Well, we can wait until YAML heuristics are merged, so we don't need to fix the heuristics.rb parser: github-linguist/linguist#4087

@smola
Copy link
Contributor Author

smola commented Sep 3, 2018

YAML heuristics just landed in master.

@bzz
Copy link
Contributor

bzz commented Oct 17, 2018

Makes perfect sense and will be happy start looking into this in couple of weeks, if there is no rush.

@bzz
Copy link
Contributor

bzz commented Jan 9, 2019

It's WIP in #189

@bzz
Copy link
Contributor

bzz commented Jan 28, 2019

As scope has grown, this has been converted to ☂️ and description was updated, linking to subsequent issues.

@bzz
Copy link
Contributor

bzz commented Feb 14, 2019

Plan to cut a v1.7.0 release as soon as heuristics.yml update from #189 lands.

Other 3 items will be left for v1.8.0

@bzz
Copy link
Contributor

bzz commented Oct 15, 2019

The last item, a detection accuracy drop, seems to be the most important at the moment.
I will get back to this, after quantifying the impact under the #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ☂️ umbrella issue
Projects
None yet
Development

No branches or pull requests

3 participants
@smola @bzz and others