Sweep (slow): #37

srikanthlogic · 2023-09-19T04:21:51Z

Details

Feature : Add a new endpoing /lists/ to support getting data from lists

/lists/category=EDUCATION&collection=new_free

gplay.list({
category: gplay.category.EDUCATION,
collection: gplay.collection.NEW_FREE,
})

Checklist

lib/index.js ✅ Commit 8887eae

• Add a new endpoint to the Express router for the path '/lists/'. This should be a GET endpoint. • In the callback function for the endpoint, check if the 'category' and 'collection' query parameters are present. If not, return an error response. • Call the 'gplay.list' function with an options object that includes the 'category' and 'collection' query parameters. • Use the '.then' function to map the results from the 'gplay.list' function using the 'cleanUrls' function. • Use another '.then' function to convert the results to the standard format using the 'toList' function. • Finally, send the results back to the client using 'res.json.bind(res)'. • Add error handling for the promise chain using the '.catch' function. Pass the 'next' function to '.catch' to ensure that errors are handled by the Express error handling middleware.

Sandbox Execution Logs

trunk init 1/31 ✓

⡿ Downloading Trunk 1.16.0...
⡿ Downloading Trunk 1.16.0...
⢿ Downloading Trunk 1.16.0...
⣻ Downloading Trunk 1.16.0...
⣽ Downloading Trunk 1.16.0...
⣾ Downloading Trunk 1.16.0...
⣷ Downloading Trunk 1.16.0...
✔ Downloading Trunk 1.16.0... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done






















✔ 14 linters were enabled (.trunk/trunk.yaml)
  actionlint 1.6.25 (4 github-workflow files)
  checkov 2.4.9 (1 docker, 5 json, 10 yaml files)
  eslint 8.49.0 (3 javascript files)
  git-diff-check (28 files)
  hadolint 2.12.0 (1 docker file) (created .hadolint.yaml)
  markdownlint 0.36.0 (2 markdown files) (created .markdownlint.yaml)
  osv-scanner 1.4.0 (1 lockfile file)
  oxipng 8.0.0 (1 png file)
  prettier 3.0.3 (3 javascript, 4 json, 2 markdown, 10 yaml files)
  taplo 0.8.1 (1 toml file)
  terrascan 1.18.3 (1 docker file)
  trivy 0.45.1 (1 docker, 1 lockfile, 10 yaml files)
  trufflehog 3.56.1 (29 files)
  yamllint 1.32.0 (10 yaml files) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io

trunk fmt lib/index.js 2/31 ✓


 ✔ Formatted lib/index.js
Re-checking autofixed files...






 ✔ Formatted lib/index.js
Re-checking autofixed files...





Checked 1 file
✔ No issues

trunk check --fix lib/index.js 3/31 ❌ (`1`)













  FAILURES  
 eslint  lib/index.js  .trunk/out/jAFe5.yaml
 eslint  lib/index.js  .trunk/out/1VVCN.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 4/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...




 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 5/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/7LMxa.yaml
 eslint  lib/index.js  .trunk/out/J3sxb.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 6/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...






 ✔ Formatted lib/index.js
Re-checking autofixed files...



Checked 1 file
✔ No issues

trunk check --fix lib/index.js 7/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/uoWYa.yaml
 eslint  lib/index.js  .trunk/out/Rx35a.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 8/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 9/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/oyYsN.yaml
 eslint  lib/index.js  .trunk/out/ACXJm.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 10/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 11/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/Kp3WT.yaml
 eslint  lib/index.js  .trunk/out/OSsDA.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 12/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...




 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 13/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/qS5mP.yaml
 eslint  lib/index.js  .trunk/out/0d08Q.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 14/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...



Checked 1 file
✔ No issues

trunk check --fix lib/index.js 15/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/GeX0G.yaml
 eslint  lib/index.js  .trunk/out/EoBDI.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 16/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...




 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 17/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/bPz02.yaml
 eslint  lib/index.js  .trunk/out/tr6yh.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 18/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...



Checked 1 file
✔ No issues

trunk check --fix lib/index.js 19/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/zVOq5.yaml
 eslint  lib/index.js  .trunk/out/FJbPe.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 20/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...




 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 21/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/u5xOm.yaml
 eslint  lib/index.js  .trunk/out/5uMJB.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 22/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 23/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/FmcYK.yaml
 eslint  lib/index.js  .trunk/out/bsSUQ.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 24/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...



Checked 1 file
✔ No issues

trunk check --fix lib/index.js 25/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/l0Y2I.yaml
 eslint  lib/index.js  .trunk/out/Tphev.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 26/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 27/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/tQlld.yaml
 eslint  lib/index.js  .trunk/out/jZ7oe.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 28/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...




 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 29/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/QPXiY.yaml
 eslint  lib/index.js  .trunk/out/8PMIW.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 30/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 31/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/tGPm6.yaml
 eslint  lib/index.js  .trunk/out/BAYQ1.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

The text was updated successfully, but these errors were encountered:

sweep-ai · 2023-09-19T04:21:58Z

Here's the PR! #39.

⚡ Sweep Free Trial: I used GPT-4 to create this ticket. You have 4 GPT-4 tickets left for the month and 2 for the day. For more GPT-4 tickets, visit our payment portal.

Actions (click)

↻ Restart Sweep

Install Sweep Configs: Pull Request

Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.

google-play-api/lib/index.js

Lines 1 to 192 in 682cdf4

    
           'use strict'; 
        
           import Express from 'express'; 
        
           import gplay from 'google-play-scraper'; 
        
           import path from 'path'; 
        
           import qs from 'querystring'; 
        
           const router = Express.Router(); 
        
           const toList = (apps) => ({ results: apps }); 
        
           const cleanUrls = (req) => (app) => Object.assign({}, app, { 
        
             playstoreUrl: app.url, 
        
             url: buildUrl(req, 'apps/' + app.appId), 
        
             permissions: buildUrl(req, 'apps/' + app.appId + '/permissions'), 
        
             similar: buildUrl(req, 'apps/' + app.appId + '/similar'), 
        
             reviews: buildUrl(req, 'apps/' + app.appId + '/reviews'), 
        
             datasafety: buildUrl(req, 'apps/' + app.appId + '/datasafety'), 
        
             developer: { 
        
               devId: app.developer, 
        
               url: buildUrl(req, 'developers/' + qs.escape(app.developer)) 
        
             }, 
        
             categories: buildUrl(req, 'categories/') 
        
           }); 
        
           const buildUrl = (req, subpath) => 
        
             req.protocol + '://' + path.join(req.get('host'), req.baseUrl, subpath); 
        
           /* App search */ 
        
           router.get('/apps/', function (req, res, next) { 
        
             if (!req.query.q) { 
        
               return next(); 
        
             } 
        
             const opts = Object.assign({ term: req.query.q }, req.query); 
        
             gplay.search(opts) 
        
               .then((apps) => apps.map(cleanUrls(req))) 
        
               .then(toList) 
        
               .then(res.json.bind(res)) 
        
               .catch(next); 
        
           }); 
        
           /* Search suggest */ 
        
           router.get('/apps/', function (req, res, next) { 
        
             if (!req.query.suggest) { 
        
               return next(); 
        
             } 
        
             const toJSON = (term) => ({ 
        
               term, 
        
               url: buildUrl(req, '/apps/') + '?' + qs.stringify({ q: term }) 
        
             }); 
        
             gplay.suggest({ term: req.query.suggest }) 
        
               .then((terms) => terms.map(toJSON)) 
        
               .then(toList) 
        
               .then(res.json.bind(res)) 
        
               .catch(next); 
        
           }); 
        
           /* App list */ 
        
           router.get('/apps/', function (req, res, next) { 
        
             function paginate (apps) { 
        
               const num = parseInt(req.query.num || '60'); 
        
               const start = parseInt(req.query.start || '0'); 
        
               if (start - num >= 0) { 
        
                 req.query.start = start - num; 
        
                 apps.prev = buildUrl(req, '/apps/') + '?' + qs.stringify(req.query); 
        
               } 
        
               if (start + num <= 500) { 
        
                 req.query.start = start + num; 
        
                 apps.next = buildUrl(req, '/apps/') + '?' + qs.stringify(req.query); 
        
               } 
        
               return apps; 
        
             } 
        
             gplay.list(req.query) 
        
               .then((apps) => apps.map(cleanUrls(req))) 
        
               .then(toList).then(paginate) 
        
               .then(res.json.bind(res)) 
        
               .catch(next); 
        
           }); 
        
           /* App detail */ 
        
           router.get('/apps/:appId', function (req, res, next) { 
        
             const opts = Object.assign({ appId: req.params.appId }, req.query); 
        
             gplay.app(opts) 
        
               .then(cleanUrls(req)) 
        
               .then(res.json.bind(res)) 
        
               .catch(next); 
        
           }); 
        
           /* Similar apps */ 
        
           router.get('/apps/:appId/similar', function (req, res, next) { 
        
             const opts = Object.assign({ appId: req.params.appId }, req.query); 
        
             gplay.similar(opts) 
        
               .then((apps) => apps.map(cleanUrls(req))) 
        
               .then(toList) 
        
               .then(res.json.bind(res)) 
        
               .catch(next); 
        
           }); 
        
           /* Data Safety */ 
        
           router.get('/apps/:appId/datasafety', function (req, res, next) { 
        
             const opts = Object.assign({ appId: req.params.appId }, req.query); 
        
             gplay.datasafety(opts) 
        
               .then(toList) 
        
               .then(res.json.bind(res)) 
        
               .catch(next); 
        
           }); 
        
           /* App permissions */ 
        
           router.get('/apps/:appId/permissions', function (req, res, next) { 
        
             const opts = Object.assign({ appId: req.params.appId }, req.query); 
        
             gplay.permissions(opts) 
        
               .then(toList) 
        
               .then(res.json.bind(res)) 
        
               .catch(next); 
        
           }); 
        
           /* App reviews */ 
        
           router.get('/apps/:appId/reviews', function (req, res, next) { 
        
             function paginate (apps) { 
        
               const page = parseInt(req.query.page || '0'); 
        
               const subpath = '/apps/' + req.params.appId + '/reviews/'; 
        
               if (page > 0) { 
        
                 req.query.page = page - 1; 
        
                 apps.prev = buildUrl(req, subpath) + '?' + qs.stringify(req.query); 
        
               } 
        
               if (apps.results.length) { 
        
                 req.query.page = page + 1; 
        
                 apps.next = buildUrl(req, subpath) + '?' + qs.stringify(req.query); 
        
               } 
        
               return apps; 
        
             } 
        
             const opts = Object.assign({ appId: req.params.appId }, req.query); 
        
             // Check if nextPaginationToken is present and not null 
        
             if (req.query.nextPaginationToken !== null) { 
        
               opts.paginate = true; 
        
               opts.nextPaginationToken = req.query.nextPaginationToken; 
        
             } 
        
             gplay.reviews(opts) 
        
               .then(toList) 
        
               .then(paginate) 
        
               .then(res.json.bind(res)) 
        
               .catch(next); 
        
           }); 
        
           /* Apps by developer */ 
        
           router.get('/developers/:devId/', function (req, res, next) { 
        
             const opts = Object.assign({ devId: req.params.devId }, req.query); 
        
             gplay.developer(opts) 
        
               .then((apps) => apps.map(cleanUrls(req))) 
        
               .then((apps) => ({ 
        
                 devId: req.params.devId, 
        
                 apps 
        
               })) 
        
               .then(res.json.bind(res)) 
        
               .catch(next); 
        
           }); 
        
           /* Developer list (not supported) */ 
        
           router.get('/developers/', (req, res) => 
        
             res.status(400).json({ 
        
               message: 'Please specify a developer id.', 
        
               example: buildUrl(req, '/developers/' + qs.escape('Wikimedia Foundation')) 
        
             })); 
        
           /* Category list */ 
        
           router.get('/categories/', function (req, res, next) { 
        
             gplay.categories() 
        
               .then(res.json.bind(res)) 
        
               .catch(next); 
        
           }); 
        
           function errorHandler (err, req, res, next) { 
        
             res.status(400).json({ message: err.message }); 
        
             next(); 
        
           } 
        
           router.use(errorHandler);

google-play-api/package.json

Lines 1 to 35 in 682cdf4

    
           { 
        
             "name": "google-play-api", 
        
             "version": "1.4.0", 
        
             "description": "turn google play scraper into a RESTful API", 
        
             "main": "server.js", 
        
             "type": "module", 
        
             "scripts": { 
        
               "test": "node --es-module-specifier-resolution=node test.js", 
        
               "generateoas": "p2o ./PostmanCollections/GooglePlayAPI.postman_collection.json -o ./openapi/options.json -f ./openapi/swagger.json", 
        
               "start": "node server.js" 
        
             }, 
        
             "author": "Facundo Olano", 
        
             "license": "ISC", 
        
             "repository": { 
        
               "type": "git", 
        
               "url": "https://github.com/srikanthlogic/google-play-api.git" 
        
             }, 
        
             "dependencies": { 
        
               "express": "^4.18.2", 
        
               "google-play-scraper": "^10.0.0", 
        
               "npm-check-updates": "^16.11.1", 
        
               "postman-to-openapi": "^3.0.1", 
        
               "swagger-ui-express": "^5.0.0" 
        
             }, 
        
             "devDependencies": { 
        
               "eslint": "^8.47.0", 
        
               "eslint-config-semistandard": "^17.0.0", 
        
               "eslint-config-standard": "^17.1.0", 
        
               "eslint-plugin-import": "^2.28.0", 
        
               "eslint-plugin-node": "^11.1.0", 
        
               "eslint-plugin-promise": "^6.1.1", 
        
               "eslint-plugin-standard": "^5.0.0", 
        
               "newman": "^5.3.2", 
        
               "newman-reporter-htmlextra": "^1.22.11" 
        
             }

google-play-api/README.md

Lines 1 to 5 in 682cdf4

    
           # google-play-api 
        
           Turns [google-play-scraper](https://github.com/facundoolano/google-play-scraper/) into a RESTful API. 
        
           ![GitHub tag (latest SemVer pre-release)](https://img.shields.io/github/v/tag/srikanthlogic/google-play-api?include_prereleases&label=version) [![Newman Run](https://github.com/srikanthlogic/google-play-api/actions/workflows/newman.yml/badge.svg)](https://github.com/srikanthlogic/google-play-api/actions/workflows/newman.yml) [![API Documentation](https://img.shields.io/badge/api-documentation-brightgreen)](https://gplayapi.cashlessconsumer.in/)

google-play-api/Dockerfile

Lines 1 to 29 in 682cdf4

    
           # Use the official Node.js image as base 
        
           FROM node:16-alpine 
        
           # Set metadata labels 
        
           LABEL maintainer="Srikanth <srikanth@cashlessconsumer.in>" \ 
        
                 version="1.0" \ 
        
                 description="Docker image for running Google Play API" 
        
           # Create and set the working directory 
        
           WORKDIR /home/node/app 
        
           # Copy only the package.json and package-lock.json first to leverage Docker caching 
        
           COPY package*.json ./ 
        
           RUN npm install -g npm@9.8.1 
        
           # Install dependencies 
        
           RUN npm ci --quiet --omit=dev 
        
           # Copy the rest of the application code 
        
           COPY . . 
        
           RUN npm run generateoas 
        
           # Expose port 3000 
        
           EXPOSE 3000 
        
           # Set the user to 'node' and run the application using npm start 
        
           USER node

google-play-api/fly.toml

Lines 1 to 20 in 682cdf4

    
           # 
        
           # See https://fly.io/docs/reference/configuration/ for information about how to use this file. 
        
           # 
        
           app = "googleplayapi" 
        
           primary_region = "sin" 
        
           [build] 
        
             image = "ghcr.io/srikanthlogic/google-play-api:main" 
        
           [services] 
        
             [services.http] 
        
               ports = ["http"] 
        
           [http_service] 
        
             protocol = "tcp" 
        
             internal_port = 3000 
        
             force_https = true 
        
             auto_stop_machines = true 
        
             auto_start_machines = true

Step 2: ⌨️ Coding

lib/index.js ✅ Commit 8887eae

• Add a new endpoint to the Express router for the path '/lists/'. This should be a GET endpoint. • In the callback function for the endpoint, check if the 'category' and 'collection' query parameters are present. If not, return an error response. • Call the 'gplay.list' function with an options object that includes the 'category' and 'collection' query parameters. • Use the '.then' function to map the results from the 'gplay.list' function using the 'cleanUrls' function. • Use another '.then' function to convert the results to the standard format using the 'toList' function. • Finally, send the results back to the client using 'res.json.bind(res)'. • Add error handling for the promise chain using the '.catch' function. Pass the 'next' function to '.catch' to ensure that errors are handled by the Express error handling middleware.

Sandbox Execution Logs

trunk init 1/31 ✓

⡿ Downloading Trunk 1.16.0...
⡿ Downloading Trunk 1.16.0...
⢿ Downloading Trunk 1.16.0...
⣻ Downloading Trunk 1.16.0...
⣽ Downloading Trunk 1.16.0...
⣾ Downloading Trunk 1.16.0...
⣷ Downloading Trunk 1.16.0...
✔ Downloading Trunk 1.16.0... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done






















✔ 14 linters were enabled (.trunk/trunk.yaml)
  actionlint 1.6.25 (4 github-workflow files)
  checkov 2.4.9 (1 docker, 5 json, 10 yaml files)
  eslint 8.49.0 (3 javascript files)
  git-diff-check (28 files)
  hadolint 2.12.0 (1 docker file) (created .hadolint.yaml)
  markdownlint 0.36.0 (2 markdown files) (created .markdownlint.yaml)
  osv-scanner 1.4.0 (1 lockfile file)
  oxipng 8.0.0 (1 png file)
  prettier 3.0.3 (3 javascript, 4 json, 2 markdown, 10 yaml files)
  taplo 0.8.1 (1 toml file)
  terrascan 1.18.3 (1 docker file)
  trivy 0.45.1 (1 docker, 1 lockfile, 10 yaml files)
  trufflehog 3.56.1 (29 files)
  yamllint 1.32.0 (10 yaml files) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io

trunk fmt lib/index.js 2/31 ✓


 ✔ Formatted lib/index.js
Re-checking autofixed files...






 ✔ Formatted lib/index.js
Re-checking autofixed files...





Checked 1 file
✔ No issues

trunk check --fix lib/index.js 3/31 ❌ (`1`)













  FAILURES  
 eslint  lib/index.js  .trunk/out/jAFe5.yaml
 eslint  lib/index.js  .trunk/out/1VVCN.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 4/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...




 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 5/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/7LMxa.yaml
 eslint  lib/index.js  .trunk/out/J3sxb.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 6/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...






 ✔ Formatted lib/index.js
Re-checking autofixed files...



Checked 1 file
✔ No issues

trunk check --fix lib/index.js 7/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/uoWYa.yaml
 eslint  lib/index.js  .trunk/out/Rx35a.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 8/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 9/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/oyYsN.yaml
 eslint  lib/index.js  .trunk/out/ACXJm.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 10/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 11/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/Kp3WT.yaml
 eslint  lib/index.js  .trunk/out/OSsDA.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 12/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...




 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 13/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/qS5mP.yaml
 eslint  lib/index.js  .trunk/out/0d08Q.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 14/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...



Checked 1 file
✔ No issues

trunk check --fix lib/index.js 15/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/GeX0G.yaml
 eslint  lib/index.js  .trunk/out/EoBDI.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 16/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...




 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 17/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/bPz02.yaml
 eslint  lib/index.js  .trunk/out/tr6yh.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 18/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...



Checked 1 file
✔ No issues

trunk check --fix lib/index.js 19/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/zVOq5.yaml
 eslint  lib/index.js  .trunk/out/FJbPe.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 20/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...




 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 21/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/u5xOm.yaml
 eslint  lib/index.js  .trunk/out/5uMJB.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 22/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 23/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/FmcYK.yaml
 eslint  lib/index.js  .trunk/out/bsSUQ.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 24/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...



Checked 1 file
✔ No issues

trunk check --fix lib/index.js 25/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/l0Y2I.yaml
 eslint  lib/index.js  .trunk/out/Tphev.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 26/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 27/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/tQlld.yaml
 eslint  lib/index.js  .trunk/out/jZ7oe.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 28/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...




 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 29/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/QPXiY.yaml
 eslint  lib/index.js  .trunk/out/8PMIW.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

trunk fmt lib/index.js 30/31 ✓

 ✔ Formatted lib/index.js
Re-checking autofixed files...



 ✔ Formatted lib/index.js
Re-checking autofixed files...




Checked 1 file
✔ No issues

trunk check --fix lib/index.js 31/31 ❌ (`1`)


  FAILURES  
 eslint  lib/index.js  .trunk/out/tGPm6.yaml
 eslint  lib/index.js  .trunk/out/BAYQ1.yaml
  NOTICES  
 [suggestion] Eslint could not resolve dependencies; try running `npm install`      
 Some tools failed to run. You can open the details yaml files for more information.
Checked 1 file
✖ No issues, 2 failures

Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/add-lists-endpoint.

.

🎉 Latest improvements to Sweep:

Getting Sweep to run linters before committing! Check out Sweep Sandbox Configs to set it up.
Added support for self-hosting! Check out Self-hosting Sweep to get started.
[Self Hosting] Multiple options to compute vector embeddings, configure your .env file using VECTOR_EMBEDDING_SOURCE

💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request.
^{Join Our Discord}

srikanthlogic added the sweep Assigns Sweep to an issue or pull request. label Sep 19, 2023

sweep-ai bot mentioned this issue Sep 19, 2023

Add new endpoint for fetching data from lists #39

Merged

srikanthlogic closed this as completed in #39 Sep 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sweep (slow): #37

Sweep (slow): #37

srikanthlogic commented Sep 19, 2023 •

edited by sweep-ai bot

Loading

sweep-ai bot commented Sep 19, 2023 •

edited

Loading

Sweep (slow): #37

Sweep (slow): #37

Comments

srikanthlogic commented Sep 19, 2023 • edited by sweep-ai bot Loading

Details

sweep-ai bot commented Sep 19, 2023 • edited Loading

Here's the PR! #39.

Actions (click)

Step 1: 🔎 Searching

Step 2: ⌨️ Coding

Step 3: 🔁 Code Review

srikanthlogic commented Sep 19, 2023 •

edited by sweep-ai bot

Loading

sweep-ai bot commented Sep 19, 2023 •

edited

Loading