Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: We are able to redirect the link to itself. #217

Closed
HarshPatel5940 opened this issue Dec 22, 2022 · 3 comments
Closed

Bug: We are able to redirect the link to itself. #217

HarshPatel5940 opened this issue Dec 22, 2022 · 3 comments
Assignees

Comments

@HarshPatel5940
Copy link
Member

HarshPatel5940 commented Dec 22, 2022

Expected Behavior

The expected behavior is we should not be able to update the link to itself or anyother kzilla.xyz/ cause it's like an infinite redirect.

Current Behavior

The Current behavior is we are able to easily achieve this in a mobile device. I have tried testing this out in a desktop browser enviorment but it blocks my ip. (This does not works in custom links cause it seems to block the link)

Failure Information

There are no checks being performed while updating the link. refrencing to Link-controller.ts line 169

Steps to Reproduce

  1. Open your mobile and go to kzilla.xyz
  2. Then just create a short link for any random link in the world, let it be youtube.com. (There is a higher success rate with randomized links so please use that for testing)
  3. Then you can go to "My Links" and update your link to itself.
  4. This basically makes a link redirect to itself infinitely.

During Step 4 you might get blocked on a desktop/laptop enviorment or atleast it seems to disable custom links after 4 redirects, But IF YOU ARE IN MOBILE AND USE THE RANDOMIZED LINK IT WORKS LIKE A CHARM

Context

Since this is able to work way better in mobile devices, i am going to consider my device for testing purposes

  • Firmware Version: None
  • Operating System: MIUI 13.0.11 ( Based on: Android 12 )
  • SDK version: None
  • Toolchain version: None

Screenshot of the bug

Screenrecorder-2022-12-22-19-39-30-649.2.mp4

Failure Logs

No Failure Logs

@HarshPatel5940
Copy link
Member Author

We need to fix our package.json too -> Source Issue By npm/yarn

@shawshankkumar
Copy link
Contributor

@sm-sami @HarshPatel5940 updates on this?

@shawshankkumar
Copy link
Contributor

Let's do this in v2.x or v3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants