Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] improve mergeable param or add a paramater for Has/Needs code review #162

Open
himynameisdave opened this issue Dec 19, 2024 · 0 comments · May be fixed by #163
Open

[feat] improve mergeable param or add a paramater for Has/Needs code review #162

himynameisdave opened this issue Dec 19, 2024 · 0 comments · May be fixed by #163

Comments

@himynameisdave
Copy link
Contributor

The mergeable parameter is pretty good, however there is one limitation with it. It will pass (when True) if all of the checks pass, however there may be other things blocking merging (specifically it may require review). See below:

image

It would be good to either:

  1. Update mergeable to account for this.
  2. Add a new param for has/needs code review.

I think if we wanted to do number 1, we could maybe read MergeableState instead so that we actually check that the PR is indeed in a clean state. I also found this Enum which I don't see in the API library so not sure if we have access to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant