code style

sspanak · Aug 1, 2023 · b68d5c6 · b68d5c6
1 parent ffc6b83
commit b68d5c6
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/src/io/github/sspanak/tt9/ime/helpers/InputType.java b/src/io/github/sspanak/tt9/ime/helpers/InputType.java
@@ -33,25 +33,27 @@ public boolean isLimited() {
 
 
 	/**
-	 * isDialer
-	 * Dialer fields seem to take care of numbers and backspace on their own,
+	 * isSpecialNumeric
+	 * Calculator and Dialer fields seem to take care of numbers and backspace on their own,
 	 * so we need to be aware of them.
 	 *
 	 * NOTE: A Dialer field is not the same as Phone field. Dialer is where you
 	 * actually dial and call a phone number. While the Phone field is a text
 	 * field in any app or a webpage, intended for typing phone numbers.
 	 *
-	 * More info: <a href="https://github.com/sspanak/tt9/issues/46">in this Github issue</a>.
+	 * More info: <a href="https://github.com/sspanak/tt9/issues/46">in this Github issue</a>
+	 * and <a href="https://github.com/sspanak/tt9/pull/326">the PR about calculators</a>.
 	 */
-	public boolean isDialer() {
+	public boolean isSpecialNumeric() {
 		if (field == null) {
 			return false;
 		}
 
 		int inputType = field.inputType & android.text.InputType.TYPE_MASK_CLASS;
 
 		return
-			inputType == android.text.InputType.TYPE_CLASS_PHONE && field.packageName.equals("com.android.dialer") || inputType == android.text.InputType.TYPE_CLASS_NUMBER && field.packageName.contains("com.android.calculator");
+			inputType == android.text.InputType.TYPE_CLASS_PHONE && field.packageName.equals("com.android.dialer")
+			|| inputType == android.text.InputType.TYPE_CLASS_NUMBER && field.packageName.contains("com.android.calculator");
 	}
 
 

diff --git a/src/io/github/sspanak/tt9/ime/helpers/TextField.java b/src/io/github/sspanak/tt9/ime/helpers/TextField.java
@@ -90,9 +90,10 @@ public ArrayList<Integer> determineInputModes(InputType inputType) {
 			return allowedModes;
 		}
 
-		// Dialer field, not to be confused with Phone text field.
-		// It only accepts 0-9, "#" and "*".
-		if (inputType.isDialer()) {
+		// Calculators (support only 0-9 and math) and Dialer (0-9, "#" and "*"),
+		// handle all input themselves, so we are supposed to pass through all key presses.
+		// Note: A Dialer field is not a Phone number field.
+		if (inputType.isSpecialNumeric()) {
 			allowedModes.add(InputMode.MODE_PASSTHROUGH);
 			return allowedModes;
 		}

diff --git a/src/io/github/sspanak/tt9/ime/modes/ModePassthrough.java b/src/io/github/sspanak/tt9/ime/modes/ModePassthrough.java
@@ -2,7 +2,7 @@
 
 import androidx.annotation.NonNull;
 
-// see: InputType.isDialer()
+// see: InputType.isSpecialNumeric()
 public class ModePassthrough extends InputMode {
 	ModePassthrough() {
 		reset();