-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hebrew support #180
Comments
I will definitely appreciate some help with adding one more language. So, if you haven't already, please check out the Adding a New Language guide. Since, you have technical knowledge, it should be very easy for you to follow it.
Please, do so in separate pull requests. |
I'm not sure but I think in the Language.java file you should write |
not help. |
@sspanak have you any ideas? |
According to the Oracle, the correct locale is iw-IL. So, I would recommend this: locale = new Locale("iw","IL"); By the way, I just realized Hebrew has no capital letters. This means adding it will require some more work. ABC mode (in capitals) needs to be disabled for such languages. But don't worry about this, I'll take care of it. I am making a note for myself, not to forget it. |
@sspanak yes. I do it, but it's not compiled.... |
@AshiVered, if this is the commit in question, then the problem is you have repeated Also, make sure not to commit the Gradle downgrade. It is OK for testing, but we don't want to use it for building the final APK. |
finish (with some issues with hebrew lang icon)! |
All issues have been resolved and Hebrew seems to be ready to release. @AshiVered, @AF1512 and anyone else following the issue, you can try out beta-18.5 and let me know if something is wrong. Otherwise, I'll merge it in the following days and it will become part of the upcoming version 19. |
Seems to work great! Not sure if I should open another issue but maybe there should be a toast notification when you change languages (maybe input modes also). |
There is one: #155. |
Seems to work great! |
Hello! It works great, but there is one problem - because of me. |
It's all good. There was just one missing word, that I added manually. I believe it is ready to release.
I can barely manage my free time at the moment and I don't have energy for any more work. Sorry, I can't help. But feel free to study this repo and use it for your own purposes. |
I'm working about it.
(Please note, my fork of Traditional T9, called Qinboard T9 supports Hebrew. But it is less sophisticated than this great fork)
Also, I'm working on contributing more features from my fork to this fork.
The text was updated successfully, but these errors were encountered: