Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hebrew support #180

Closed
AshiVered opened this issue Feb 10, 2023 · 15 comments · Fixed by #197
Closed

Add Hebrew support #180

AshiVered opened this issue Feb 10, 2023 · 15 comments · Fixed by #197
Assignees
Labels
languages Dictionary or language related issues

Comments

@AshiVered
Copy link
Contributor

AshiVered commented Feb 10, 2023

I'm working about it.
(Please note, my fork of Traditional T9, called Qinboard T9 supports Hebrew. But it is less sophisticated than this great fork)
Also, I'm working on contributing more features from my fork to this fork.

@sspanak sspanak added the languages Dictionary or language related issues label Feb 13, 2023
@sspanak
Copy link
Owner

sspanak commented Feb 13, 2023

I will definitely appreciate some help with adding one more language.

So, if you haven't already, please check out the Adding a New Language guide. Since, you have technical knowledge, it should be very easy for you to follow it.

Also, I'm working on contributing more features from my fork to this fork.

Please, do so in separate pull requests.

@AshiVered
Copy link
Contributor Author

I am trying to compile the code, after adding Hebrew, but I have some problems
image
I am not a very experienced programmer, and I did not find (let's start with the first error) the class "Locale" where the variable "hebrew" is not present.
Is it related to
java.util.Locale
?

@AF1512
Copy link

AF1512 commented Feb 19, 2023

I'm not sure but I think in the Language.java file you should write locale = new Locale("he","HE"); (based on the other Languages.java).

@AshiVered
Copy link
Contributor Author

not help.
this is my code.
https://github.com/AshiVered/tt9

@AshiVered
Copy link
Contributor Author

@sspanak have you any ideas?

@sspanak
Copy link
Owner

sspanak commented Feb 20, 2023

According to the Oracle, the correct locale is iw-IL. So, I would recommend this:

locale = new Locale("iw","IL");

By the way, I just realized Hebrew has no capital letters. This means adding it will require some more work. ABC mode (in capitals) needs to be disabled for such languages. But don't worry about this, I'll take care of it. I am making a note for myself, not to forget it.

@AshiVered
Copy link
Contributor Author

According to the Oracle, the correct locale is iw-IL. So, I would recommend this:

locale = new Locale("iw","IL");

@sspanak yes. I do it, but it's not compiled....

@sspanak
Copy link
Owner

sspanak commented Feb 20, 2023

@AshiVered, if this is the commit in question, then the problem is you have repeated locale = .... Assign it only once and it will work. 😉

Also, make sure not to commit the Gradle downgrade. It is OK for testing, but we don't want to use it for building the final APK.

@AshiVered
Copy link
Contributor Author

finish (with some issues with hebrew lang icon)!
see this pull request
download built apk (debug)
https://github.com/AshiVered/tt9/releases/tag/0.1

@sspanak sspanak self-assigned this Feb 28, 2023
@sspanak sspanak mentioned this issue Feb 28, 2023
@sspanak
Copy link
Owner

sspanak commented Mar 1, 2023

All issues have been resolved and Hebrew seems to be ready to release.

@AshiVered, @AF1512 and anyone else following the issue, you can try out beta-18.5 and let me know if something is wrong. Otherwise, I'll merge it in the following days and it will become part of the upcoming version 19.

@AF1512
Copy link

AF1512 commented Mar 2, 2023

Seems to work great! Not sure if I should open another issue but maybe there should be a toast notification when you change languages (maybe input modes also).

@sspanak
Copy link
Owner

sspanak commented Mar 2, 2023

... maybe there should be a toast notification when you change languages (maybe input modes also).

There is one: #155.

@DarthFlip
Copy link
Contributor

Seems to work great!

@AshiVered
Copy link
Contributor Author

Hello! It works great, but there is one problem - because of me.
The database I uploaded is causing problems...
A proper database is attached.
Sorry!
P.S. I need a little help with changing UI colors in my fork of clam's tt9. can you help me? Thank you!
he-utf8.txt

@sspanak
Copy link
Owner

sspanak commented Mar 6, 2023

Hello! It works great, but there is one problem - because of me.
The database I uploaded is causing problems...
A proper database is attached.
Sorry!

It's all good. There was just one missing word, that I added manually. I believe it is ready to release.

P.S. I need a little help with changing UI colors in my fork of clam's tt9. can you help me? Thank you!

I can barely manage my free time at the moment and I don't have energy for any more work. Sorry, I can't help. But feel free to study this repo and use it for your own purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
languages Dictionary or language related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants