Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"0" key not working for touch tones #225

Closed
lgexalter opened this issue Mar 23, 2023 · 13 comments
Closed

"0" key not working for touch tones #225

lgexalter opened this issue Mar 23, 2023 · 13 comments
Assignees
Labels
bug Something isn't working

Comments

@lgexalter
Copy link

lgexalter commented Mar 23, 2023

When dialing a number if zero is pressed it works fine, because it shows up on the screen, but no sound is made unlike the other numbers. This makes a difference when 0 is needed for touch tones. E.g. my voicemail password is 0000 and the voicemail does not recognize that anything was dialed when pressing 0.

N.b. I'm obviously kidding about my voicemail password 😝

@lgexalter
Copy link
Author

@sspanak Was this fixed in the latest release? I saw you wrote something about fixing dialer field detection

@sspanak
Copy link
Owner

sspanak commented Apr 5, 2023

No, I haven't even reviewed this one. If it was fixed, I would have closed it.

The dialer field is the one where you type a phone number to call someone. I believe, it is not related to your case.

@DarthFlip
Copy link
Contributor

I just came across this issue also. I was trying to order something over the phone and I couldnt key in the 0's in the credit card number. I had to hang up, switch ime, then recall.

@sspanak
Copy link
Owner

sspanak commented Apr 10, 2023

I've noticed some issues with 0 in Numeric mode, while I was working on #159. It is most likely another manifestation of the same problem.

@DarthFlip , @lgexalter , I need to know, when you face the issue, are you in Numeric mode? In other words, when you press the keys, do any letters appear or only digits?

@sspanak sspanak added the bug Something isn't working label Apr 13, 2023
@DarthFlip
Copy link
Contributor

It was in Numeric mode and correctly displayed the "0" on the screen along with all the other numbers, however the automated system that I was on the phone with only recognized the other numbers. (On the screen it showed I had typed "12012" and the automated system said I had only typed in "1212").

@lgexalter
Copy link
Author

Same as @DarthFlip

@sspanak sspanak self-assigned this Apr 19, 2023
@mcfrei
Copy link
Contributor

mcfrei commented Apr 19, 2023

Could that be connected with the fact that all entries of 0 disappear for me on KYF33 in the calling interface as soon as I press any other key? like this:
*
*6
*60
*600
*6000
*6#

@sspanak
Copy link
Owner

sspanak commented Apr 20, 2023

@mcfrei, perhaps. I've definitely found problems with 123 mode and fixed them. It sounds like there may something else on your phone, but it may have the same root cause, as well. So, could you please try out the latest beta release and let me know if the problem is resolved?

Also, pinging @lgexalter and @DarthFlip.

Have in mind typing words may lag a bit in the beta, but I am going to optimize it in the final version.

@mcfrei
Copy link
Contributor

mcfrei commented Apr 20, 2023

@sspanak Thank you so much!

The problems with disappearing 0 entries in the calling app are fixed in the latest beta release for me!

However, there seems to be a slight other issue in the latest beta release for me, that the "Backspace" operation that deletes last symbol, does not abide to the configuration settings anymore - it is set to the key that is labeled as F3 in settings (keyCode 134 scanCode 62), but when the numbers are entered in the calling app, the "Back" key (keyCode 4 scanCode 355) produces "Backspace" operation instead, and the F3 key does nothing.

@sspanak
Copy link
Owner

sspanak commented Apr 21, 2023

@mcfrei, if it is only the calling app, this is intentional and it is like this since the beginning. Calling (dialer) apps handle the keypad on their own. I am not aware of any way of changing this. If Backspace does not work properly in all apps, please create a new issue. This one is about 0-key.

@lgexalter
Copy link
Author

@sspanak Seems to be fixed. Thank you!

@mcfrei
Copy link
Contributor

mcfrei commented Apr 26, 2023

I was able to build a debug version and check it on the phone.

The problem I mentioned earlier, with disappearing 0 key, is still present in the latest master commit I have (7f6cd61) marked with 20.0 tag.

However this problem is absent in the latest beta release you shared earlier, and in the build from the branch soft-keyboard-numpad (221cc21).

Other comments moved to issue #261

@sspanak
Copy link
Owner

sspanak commented Apr 27, 2023

@mcfrei, please create a new issues for the Backspace problem and, if possible, please move your comment(s) about it there. Also, you may want to wait for #242 and #243, where I have fixed many small bugs.

And last but not least, thank you for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants