Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ModeDialer #255

Closed
sspanak opened this issue May 10, 2023 · 0 comments · Fixed by #258
Closed

Add ModeDialer #255

sspanak opened this issue May 10, 2023 · 0 comments · Fixed by #258
Assignees
Labels
technical Refactoring without user-facing or functional changes

Comments

@sspanak
Copy link
Owner

sspanak commented May 10, 2023

Extend Mode123 with a new ModeDialer. This will further reduce the usage of mEditing and hopefully resolve punctuation typing problems in 123 mode using the on-screen keyboard. Also, this will make it easier to fix #246.

  • Move hold-0-to-type-plus in ModeDialer. Not a good idea. Decided to keep it in 123 after all.
  • In TraditionalT9 class, replace all usages of mEditing == DIALER with a check for the new InputMode
  • Both modes must have isNumeric(), replacing the current is123(), in order to replace mEditing == STRICT_NUMERIC.
@sspanak sspanak added the technical Refactoring without user-facing or functional changes label May 10, 2023
@sspanak sspanak self-assigned this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Refactoring without user-facing or functional changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant