Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command palette #263

Closed
sspanak opened this issue May 25, 2023 · 3 comments · Fixed by #528
Closed

Add a command palette #263

sspanak opened this issue May 25, 2023 · 3 comments · Fixed by #528
Labels
enhancement New feature or request

Comments

@sspanak
Copy link
Owner

sspanak commented May 25, 2023

For easier access to functions on phones with few hardware buttons, it would be easier to invoke the respective functions with star+number combos, instead of with hotkeys. For example, #83 and #170 would require multiple key control keys.

Also, the hotkey processing is getting more and more complex, which is not the way to go.

To resolve this, add a command palette:

  • Split TraditionalT9 class in three logical pieces.
    • TypingHandler extends KeyPadHandler. It contains 0-9, Ok and backspace processing code.
    • HotkeyHandler extends TypingHandler. It contains the hotkey code
      TraditionalT9 is on top and contains tools like getting the context and whatnot
  • Add a "show commands" hotkey. It will display a numbered list of commands. Default key is: "*".
  • Pressing a number when the command palette is on invokes the respective command.
  • Command list: 1. Add word; 2. Show settings
  • Remove the "Add Word" and "Show Settings" hotkeys.
  • Make sure the command palette fits well, when the on-screen keyboard is on.
  • Make the list touchable, so it can be used on a device without a hardware keypad.
  • Remove Add word and settings handling from KeyPadHandler. Done in another issue.
  • Make a migration for resetting the hotkeys There is no need to migrate anything. The old hotkeys will simply not exist.
@sspanak sspanak added the enhancement New feature or request label May 25, 2023
@sspanak sspanak added this to the v23.0 milestone May 25, 2023
@sspanak sspanak modified the milestones: v23.0, Next Generation Jun 6, 2023
This was referenced Aug 3, 2023
@stianhoiland
Copy link

I suggest leaving in the Add Word and Show Settings hotkeys. It just increases the customizability available to people. Some people prefer weird things!

@sspanak
Copy link
Owner Author

sspanak commented Aug 14, 2023

Well, I suppose there is no harm in leaving the hotkeys.

@sspanak sspanak modified the milestones: Next Generation, Command Palette Oct 3, 2023
@sspanak sspanak removed this from the Command Palette milestone Mar 28, 2024
@sspanak sspanak linked a pull request May 29, 2024 that will close this issue
@sspanak
Copy link
Owner Author

sspanak commented May 30, 2024

After all, I've decided to reduce the number of hotkeys to minimum to make the code simpler and easier to maintain. I believe the new command palette will be convenient enough to compensate for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants