Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggressive suggestion of words with apostrophe in Ukrainian #579

Closed
WallK opened this issue Jul 19, 2024 · 2 comments · Fixed by #591
Closed

Aggressive suggestion of words with apostrophe in Ukrainian #579

WallK opened this issue Jul 19, 2024 · 2 comments · Fixed by #591
Labels
bug Something isn't working

Comments

@WallK
Copy link
Contributor

WallK commented Jul 19, 2024

Hello!
When I type a word and want to add a comma after it AND the word happens to be sharing the same key combo as another word that has apostrophe in this place -- I get always suggested this word
This happens surprisingly often!
See video below
Suggested behavior: suggest this apostrophe containing word only if next letter after apostrophe is inputted
In my example -- only after 3 or 9 is pressed (приб'є or приб'ю)
Meaning 56421 should produce "Осіб," (assuming my state of suggestions), 564213 should produce "Приб'є"
I hope I've explained is at least half understandable (:

Video:

video_2024-07-19_05-37-04.mp4
@sspanak
Copy link
Owner

sspanak commented Jul 19, 2024

I understand the problem very well and I've been banging my head for months searching for a solution for typing words with apostrophes.

During the past year, only Ukrainian, but also French and likely Italian and Hebrew, have transitioned from "nearly unusable" to "almost there". There were many problems with English as well.

Now, as for your problem, you can get "осiб," but you need to scroll back, then forth the suggestion list, then hit 1-key to append the comma. Alternatively, always press OK to accept the current word, before typing the comma. These are the workarounds until I find a solution.

I believe the actual solution is to:

  1. Always preserve the current suggestion before the next database search.
  2. If there is no exact match for word+1, display the previous word+added punctuation.
  3. Otherwise, display the exact match.

@sspanak sspanak added the bug Something isn't working label Jul 19, 2024
@WallK
Copy link
Contributor Author

WallK commented Jul 19, 2024

I do press ok in those cases, but I'm typing too fast to notice sometimes! (:
Your proposed solution seems like just what will fix our gripes, thank you!

@sspanak sspanak linked a pull request Aug 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants