Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft keyboard numpad #231

Merged
merged 6 commits into from
Apr 21, 2023
Merged

Soft keyboard numpad #231

merged 6 commits into from
Apr 21, 2023

Conversation

nebkrid
Copy link
Contributor

@nebkrid nebkrid commented Mar 28, 2023

continuing #188

If I haven't answered or have forgotten about some of your questions, just copy them and I'll do there.
Now, regarding the long press to type a number, this may not be strictly necessary on touchscreen keyboard. From what I saw, all other keyboards, require manually switching to numeric mode to type numbers, which means we are all good in this regard.

I think when we skip the long-press-to-type-number-function all discussed points are now solved - except from the restructuring which you have in mind.

@sspanak sspanak self-assigned this Apr 13, 2023
@sspanak
Copy link
Owner

sspanak commented Apr 13, 2023

@nebkrid, I ended up refactoring quite a lot of code. I had squash everything into a single commit for easier conflict solving and updating with master. This means, if you want to use the branch again, you must pull with:

$ git pull --rebase

@sspanak sspanak force-pushed the soft-keyboard-numpad branch 10 times, most recently from 19d514d to 99515fd Compare April 19, 2023 12:04
@sspanak sspanak linked an issue Apr 19, 2023 that may be closed by this pull request
Add an on-screen numpad for use on any smartphone #159
Closed
nebkrid and others added 5 commits April 19, 2023 15:15
@nebkrid @sspanak
Touchscreen support + small improvements
404870d 
* Soft-Keyboard numpad

* no more SoftKeyHandler, the main view is in its own package

* settings are no longer passed unnecessarilly here and there

* fixed numeric mode not working in some cases

* simplified suggestion handling

* fixed crashing when changing the phone orientation
@sspanak
big code cleanup and code style fixes of the entire project
ba2451b
@sspanak
added numpad separators and imporved the overall readability
0afa4d7
@sspanak
ignored key presses are now properly passed back to Android
85b484f
@sspanak
added support for Volume Up and Volume Down keys
221cc21
@sspanak
Fixed on-screen keys holding
0c1f374 
	* Backspace works properly

	* holding 0-key now types '+' in 123 mode

	* holding the punctuation keys now allows for typing ',' and '.' in 123 mode
@sspanak sspanak self-requested a review April 21, 2023 08:32
@sspanak sspanak merged commit b8b05c6 into master Apr 21, 2023
@sspanak sspanak deleted the soft-keyboard-numpad branch April 21, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sspanak sspanak sspanak approved these changes

Assignees

@sspanak sspanak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an on-screen numpad for use on any smartphone
2 participants
@nebkrid @sspanak