fix nullref on exiting dialer by long pressing of Back key on KYF33 #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sspanak
requested changes
May 25, 2023
|
I have updated the code, thank you for a prompt review and a good point on object lifecycle that I have missed. |
sspanak
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FATAL EXCEPTION: main
Process: io.github.sspanak.tt9, PID: 13729
java.lang.NullPointerException: Attempt to invoke virtual method 'void io.github.sspanak.tt9.ime.helpers.TextField.setComposingText(java.lang.CharSequence)' on a null object reference
at io.github.sspanak.tt9.ime.TraditionalT9.clearSuggestions(TraditionalT9.java:476)
at io.github.sspanak.tt9.ime.TraditionalT9.onStop(TraditionalT9.java:190)
at io.github.sspanak.tt9.ime.TraditionalT9.onStart(TraditionalT9.java:161)
at io.github.sspanak.tt9.ime.KeyPadHandler.onStartInput(KeyPadHandler.java:81)
at io.github.sspanak.tt9.ime.TraditionalT9.onStartInput(TraditionalT9.java:27)
at android.inputmethodservice.InputMethodService.doStartInput(InputMethodService.java:1651)
at android.inputmethodservice.InputMethodService$InputMethodImpl.startInput(InputMethodService.java:411)
at android.inputmethodservice.IInputMethodWrapper.executeMessage(IInputMethodWrapper.java:172)
at com.android.internal.os.HandlerCaller$MyHandler.handleMessage(HandlerCaller.java:37)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5276)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:941)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:736)