removed the last of the legacy Backspace hack #318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When testing on a consumer cellular link ii where the clear key also doubles as the back key:
and it is meant to delete text when there is text, otherwise double as a back key for system navigation.
I was not able to back out of a text conversation because I would be on a textbox which calls for the keypad and isBackspaceHandled was always returning true here. It wasn't returning true because of onBackspace() but because the keyCode was 67 (KeyEvent.KEYCODE_DEL) and was returning true for the second part of the OR statement.
Solution:
Removed second part of conditional. onBackspace() already checks whether there's text or if it's in passthrough. Open to discussing the logic here, but it doesn't seem necessary to have this OR statement.