Mode refactoring again #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sspanak
force-pushed
the
mode-refactoring-again
branch
3 times, most recently
from
81e9334
to
3c2726d
Compare
sspanak
force-pushed
the
mode-refactoring-again
branch
3 times, most recently
from
99282f1
to
ca292e4
Compare
…gned to them * Mode123 types numbers as text again, instead of using key codes * removed the InputMode.onOtherKey() functionality, all "other" stuff will be typed as text from now on * slightly optimized TraditionalT9.getComposingText() to return faster when there is no text
sspanak
force-pushed
the
mode-refactoring-again
branch
from
ca292e4
to
1f2bc8a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross fingers this is the fix for:
#300, #290 and #241.EDIT: It does not fix #300 😢