Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added OR operator for calculator app #326

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Conversation

alexknop
Copy link
Contributor

Problem: When using the Calculator app, the status bar was showing and covering part of the UI. I felt it made more sense to use passthrough here, similar to the dialer. It also allows me to press * and insert a decimal point on the calculator app
image

Solution: in isDialer() function, also consider when the inputType is android.text.InputType.TYPE_CLASS_NUMBER

@sspanak sspanak self-requested a review July 31, 2023 09:14
@alexknop
Copy link
Contributor Author

Yes, I have added a placeholder for it to also be the calculator app.
I used contains because my package name was technically "com.android.calculator2" but I bet there are package names that are just "com.android.calculator"

@sspanak
Copy link
Owner

sspanak commented Aug 1, 2023

Yes, I have added a placeholder for it to also be the calculator app.
I used contains because my package name was technically "com.android.calculator2" but I bet there are package names that are just "com.android.calculator"

Yeah, I think this is good enough. I can't test this, because my calculator has its own keyboard, but I believe the fix is fine.

I've also renamed isDialer() in your branch, because it no longer checks only for Dialer fields. I hope that's OK.

@sspanak sspanak merged commit d4c6467 into sspanak:master Aug 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants