Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Ukrainian translation #440

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Updated Ukrainian translation #440

merged 2 commits into from
Feb 23, 2024

Conversation

WallK
Copy link
Contributor

@WallK WallK commented Feb 23, 2024

Also hanged locale name to be "ua"

@WallK
Copy link
Contributor Author

WallK commented Feb 23, 2024

Previous translation had a lot of errors and looked like a translation from Russian

@WallK
Copy link
Contributor Author

WallK commented Feb 23, 2024

Also, why are some things non-translatable?
For example "Cannot add a word when no language is selected." is marked as non-translatable

@sspanak
Copy link
Owner

sspanak commented Feb 23, 2024

Thanks for updating the translations. However, could you please change the base of your branch to version-28 instead of master? I am about to merge it and release the new version, but I have added some more strings there. It would be nice if they are properly translated, too.

@WallK
Copy link
Contributor Author

WallK commented Feb 23, 2024

Sure, will do

res/values-ua/strings.xml Outdated Show resolved Hide resolved
res/values-ua/strings.xml Outdated Show resolved Hide resolved
res/values-ua/strings.xml Outdated Show resolved Hide resolved
res/values-ua/strings.xml Outdated Show resolved Hide resolved
@sspanak
Copy link
Owner

sspanak commented Feb 23, 2024

Previous translation had a lot of errors and looked like a translation from Russian

I tried my best with Google Translate and with some help from Ukrainian friends. But I don't speak the language and I didn't really want to bother them all the time, so... 🙂

@sspanak sspanak added the languages Dictionary or language related issues label Feb 23, 2024
@sspanak sspanak changed the base branch from master to version-28 February 23, 2024 13:10
@WallK
Copy link
Contributor Author

WallK commented Feb 23, 2024

Do you want me rebasing to version-28 and putting new translation in the \app\src\main\res\values-ua\ ?

@sspanak
Copy link
Owner

sspanak commented Feb 23, 2024

Do you want me rebasing to version-28 and putting new translation in the \app\src\main\res\values-ua\ ?

Yes, this is the correct path now.

@sspanak
Copy link
Owner

sspanak commented Feb 23, 2024

@WallK, I am not sure if you want to continue working in this PR or open a new one, but whatever you choose, could you also change the pref_hack_key_pad_debounce_time key to "Key Repeat Protection" or "Accidental Key Repeat Protection", whatever sounds better in Ukrainian? I will change it in all other languages.

Sorry for the last minute change, but I think this is a bit more clear than "Multi-press protection".

@WallK WallK reopened this Feb 23, 2024
@WallK
Copy link
Contributor Author

WallK commented Feb 23, 2024

Rebase closed the PR automatically (???)
Had an urgent matter at work, but this commit should be better
I already translated something along the lines of "Accidental Key Repeat Protection" because "Multi-press protection" didn't make a nice sentence in Ukrainian, glad we thought alike

@WallK WallK requested a review from sspanak February 23, 2024 14:55
@sspanak sspanak changed the base branch from version-28 to docs-28 February 23, 2024 15:13
@sspanak sspanak merged commit f910c8d into sspanak:docs-28 Feb 23, 2024
1 check passed
@sspanak
Copy link
Owner

sspanak commented Feb 23, 2024

@WallK, Android doesn't understand the "ua" locale and displays no translations. I'll restore it to "uk" in #441.

@WallK
Copy link
Contributor Author

WallK commented Feb 23, 2024

Ok, I was to hasty and the real language code is "uk", sorry
I guess you should rename the folder back...

sspanak pushed a commit that referenced this pull request Feb 23, 2024
sspanak pushed a commit that referenced this pull request Feb 24, 2024
sspanak pushed a commit that referenced this pull request Feb 24, 2024
sspanak pushed a commit that referenced this pull request Feb 24, 2024
sspanak pushed a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
languages Dictionary or language related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants