Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balar does not compile as written #2404

Closed
mgoldstein322 opened this issue Oct 2, 2024 · 3 comments
Closed

Balar does not compile as written #2404

mgoldstein322 opened this issue Oct 2, 2024 · 3 comments

Comments

@mgoldstein322
Copy link

Compiling balar requires the user to comment out line 19 of balarTestCPU.cc. This line is #include <sst/core/simulation.h>, which does not exist. Replacing the line with #include <sst/core/simulation_impl.h> does not solve the compilation issue. Additionally, running the balar tests afterward produces a segmentation fault.

How to reproduce:

Compile balar by following the instructions at https://github.com/sstsimulator/sst-elements/blob/master/src/sst/elements/balar/README.md but comment out line 19 of balarTestCPU.cc so that compilation will complete. Next, run sst testBalar-testcpu.py --model-options='-c gpu-v100-mem.cfg -v -x vectorAdd/vectorAdd -t vectorAdd/cuda_calls.trace'. The test will complete and display the "Test Completed Successfully" message, then seg fault.

RHEL9 -- CUDA 11 -- SST core commit 0075ba17 -- SST elements commit 4c91414

@jwilso
Copy link
Contributor

jwilso commented Oct 14, 2024

@hughes-c Any progress on this issue? It would be nice to get it into 14.1.0.

@jwilso jwilso modified the milestones: SST v14.1.0, SST v14.2.0 Oct 14, 2024
@jwilso
Copy link
Contributor

jwilso commented Oct 14, 2024

@gvoskuilen This will be deferred to a later release. For 14.1.0, documentation will note this as an open issue.

@hughes-c
Copy link
Member

Closing this since #2428 makes changes to balar and the build requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants