-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in ItemSearch._format_datetime giving wrong date #91
Comments
I'm not sure I agree with the expected result, I think it should be exactly what was given but with timezone added, e.g.
The caller could be specifying an exact time down to the seconds value, so we can't assume they wanted the end of that minute, correct? I think the syntax to specify "end of the minute" would be the awkward |
Oh, yeah I think you're right. Just to confirm some expected behavior, the idea is that if a resolution is not specified, then those will be filled as their highest value. For example, if you only specify up to minutes, then seconds will be filled as 59
|
Two corrections:
|
Gotcha, thanks. I think that https://pystac-client.readthedocs.io/en/latest/client.html#pystac_client.ItemSearch covers that
and I can't really think of a better way to phrase it, so sounds good to me. |
It looks like
_format_datetime
ignores components like the seconds in the right side of the range.I think the expected result is
The text was updated successfully, but these errors were encountered: