/collections route returns array

[jisantuc]

The /collections route according to the API spec returns an object with collections and links keys --

• route
• capital C collections
• lowercase c collections

The deployed version of the API that I saw this on was based on this branch so I don't know if this is also true on master. If not I won't be offended by a quick close.

[lossyrob]

This was fixed, but a regression that was introduced in a recent refactor.

The response model for the collections endpoint is Collections, which is the correct format; however, all_collections on the backends and the base class (

stac-fastapi/stac_fastapi/types/stac_fastapi/types/core.py

Line 384 in 9ef8601

def all_collections(self, **kwargs) -> List[stac_types.Collection]:

) return a list of TypeDict Collection objects.

This should instead construct a stac-pydantic Collections object or a TypedDict with the appropriate entries, and return with the appropriate links (see the PC endpoint for reference)

This could either be solved by changing the all_collections signature and modifying the backend core clients, or translating the list of collections at the API level so that all backends use the same logic to construct the Collections response