Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test catalogs do not pass validation #152

Closed
gadomski opened this issue Jun 23, 2021 · 0 comments · Fixed by #243
Closed

Test catalogs do not pass validation #152

gadomski opened this issue Jun 23, 2021 · 0 comments · Fixed by #243
Labels
bug Something isn't working
Milestone

Comments

@gadomski
Copy link
Member

As I was playtesting #151, I discovered that several of our test catalogs do not pass validation, e.g.:

(stactools) ➜  stactools git:(feature/stac-validate) stac validate tests/data-files/catalogs/planet-example-1.0.0-beta.2/collection.json
Validation failed for COLLECTION at tests/data-files/catalogs/planet-example-1.0.0-beta.2/collection.json with ID planet-disaster-data against schema at https://schemas.stacspec.org/v1.0.0/collection-spec/json-schema/collection.json
'2017-08-28T10:00:00-08:00' does not match '(\\+00:00|Z)$'

Failed validating 'pattern' in schema['allOf'][0]['properties']['extent']['properties']['temporal']['properties']['interval']['items']['items']:
    {'format': 'date-time',
     'pattern': '(\\+00:00|Z)$',
     'type': ['string', 'null']}

On instance['extent']['temporal']['interval'][0][0]:
    '2017-08-28T10:00:00-08:00'

tests/data-files/catalogs/test-case-1/catalog.json fails as well, and I'm sure there's more. We should add test cases that ensure that all of our test data files are valid.

@gadomski gadomski added the bug Something isn't working label Jun 23, 2021
@gadomski gadomski added this to the v0.2.1 milestone Jun 23, 2021
@gadomski gadomski removed this from the v0.2.1 milestone Jul 28, 2021
@gadomski gadomski added this to the v0.3.0 milestone Feb 14, 2022
@gadomski gadomski mentioned this issue Feb 17, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant