Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libc detection is not supported #1162

Open
1 task done
privatenumber opened this issue Aug 17, 2023 · 0 comments
Open
1 task done

libc detection is not supported #1162

privatenumber opened this issue Aug 17, 2023 · 0 comments

Comments

@privatenumber
Copy link

privatenumber commented Aug 17, 2023

Describe the bug

As mentioned in #1161, all package managers support the libc property now. However, libc doesn't seem mocked/supported in WebContaiers.

I tested the detection logic of npm, pnpm, and yarn here, and all of them return null:
https://stackblitz.com/edit/stackblitz-starters-hkv5ph?file=index.js

This causes all libc distributions to get installed.

For example, when installing @swc/core via pnpm, both @swc/core-linux-x64-musl and @swc/core-linux-x64-gnu are installed:

https://stackblitz.com/edit/stackblitz-starters-2ap9g3?file=package.json

Link to the blitz that caused the error

https://stackblitz.com/edit/stackblitz-starters-hkv5ph?file=index.js

Steps to reproduce

Open links above.

Expected behavior

For libc to be mocked, and for the package managers to pick the appropriate libc distribution so extra packages aren't installed unnecessarily.

Parity with Local

Screenshots

No response

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 91.1]

Additional context

privatenumber/pkg-size.dev#21 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant