Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NIP-44 encryption for NWC #1699

Open
ekzyis opened this issue Dec 10, 2024 · 2 comments
Open

Support NIP-44 encryption for NWC #1699

ekzyis opened this issue Dec 10, 2024 · 2 comments
Labels
feature new product features that weren't there before wallets

Comments

@ekzyis
Copy link
Member

ekzyis commented Dec 10, 2024

Describe the problem you're trying to solve

NWC wallets will add versioning and switch to NIP-44 encryption at some point, see nostr-protocol/nips#1531.

We are about to switch to NDK (#1590), but it doesn't seem to support NIP-44 for NWC specifically yet. However, the NDKPrivateSigner has NIP-44 encryption support.

Describe the solution you'd like

What's needed is to detect which encryption scheme the wallet supports (nip04 or nip44) as specified in nostr-protocol/nips#1531 and then encrypt requests with the corresponding scheme.

Describe alternatives you've considered

n/a

Additional context

There is some work currently being done in NDK regarding migration to NIP-44 for other NIPs (nostr-dev-kit/ndk#279) but not for NWC afaict.

@ekzyis ekzyis added feature new product features that weren't there before wallets labels Dec 10, 2024
@riccardobl
Copy link
Member

i don't think we should try to monkeypatch NDK from our side, if anything, we should PR it to the NDK repo

@ekzyis
Copy link
Member Author

ekzyis commented Dec 10, 2024

Yes, or we fork it and do it ourselves since the maintainers don't seem to be very responsive. This ticket is just about keeping track that we need to find a solution.

@ekzyis ekzyis changed the title Migrate to NIP-44 encryption for NWC Support NIP-44 encryption for NWC Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new product features that weren't there before wallets
Projects
None yet
Development

No branches or pull requests

2 participants