Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Plugin incompatible with darkmode #230

Open
Elyytscha opened this issue Mar 3, 2023 · 4 comments
Open

Bug Plugin incompatible with darkmode #230

Elyytscha opened this issue Mar 3, 2023 · 4 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@Elyytscha
Copy link

When you use the darkmode in jenkins
image

the plugin output is looking like this:
stackrox_jplug_violates_darkmode

@janisz
Copy link
Contributor

janisz commented Mar 16, 2023

AFAIK dark mode is only available via plugin. What plugin are you using?

@janisz
Copy link
Contributor

janisz commented Mar 16, 2023

OK, it was introduced in jenkins with css variables

@janisz janisz added good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest labels Mar 16, 2023
@janisz
Copy link
Contributor

janisz commented Mar 16, 2023

I played with it for a while. I think it could work but the biggest problem is bootstrap css and how to handle color in it.

@Elyytscha
Copy link
Author

i think / imo its no problem if its not the exact same colors like jenkins uses for darkmode, would be enough if it just fits somehow and ui gets readable (actually as you can see on the left side, you can't read anything with darkmode toggled on)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants