Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pox: Disallow stacking locks during prepare phase #3775

Open
friedger opened this issue Jul 1, 2023 · 4 comments
Open

Pox: Disallow stacking locks during prepare phase #3775

friedger opened this issue Jul 1, 2023 · 4 comments
Labels
PoX Proof-of-Transfer Related

Comments

@friedger
Copy link
Collaborator

friedger commented Jul 1, 2023

Is your feature request related to a problem? Please describe.
As a stacker, I lock my stacks before the start of the cycle but after the start of the prepare phase and my stx do not earn any rewards

Describe the solution you'd like
Currently, there is no way to learn about the cycle anchor block. It would be nice to include that information in an api.
Furthermore, the stacking transactions with (delegate-) stack-stx, (delegate-) stack-extend/increase should fail if called during the prepare phase.

additional context
See "Not earning locked stx" table on https://stacksonchain.com/dashboards/Fast%20Pool/276

The discussion on discord led to this feature request: https://discord.com/channels/621759717756370964/730814571517968436/1112787020117463100

@friedger
Copy link
Collaborator Author

Added check-not-prepare-phase in https://github.com/stacks-network/stacks-blockchain/tree/feat/pox-4

@friedger friedger moved this from Status: 🆕 New to Status: 💻 In Progress in Stacks Core Eng Sep 25, 2023
@friedger
Copy link
Collaborator Author

friedger commented Sep 28, 2023

Blocked by #3976

@friedger
Copy link
Collaborator Author

There is a discussion for this topic: #4193

@friedger friedger moved this from Status: 💻 In Progress to Status: 📋 Backlog in Stacks Core Eng Jan 10, 2024
@friedger friedger removed their assignment Jan 24, 2024
@kantai
Copy link
Member

kantai commented Apr 25, 2024

This wasn't implemented in pox-4, which means this feature request, if implemented, would require a pox-5. This means that it cannot be 3.0 activated, so removing the nakamoto tags from this for now.

@kantai kantai added PoX Proof-of-Transfer Related and removed argon3.0 labels Apr 25, 2024
@kantai kantai changed the title [pox-4] Improve stacking deadline handling Pox: Disallow stacking locks during prepare phase Apr 25, 2024
@saralab saralab added this to the Nakamoto-3.0.x milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PoX Proof-of-Transfer Related
Projects
Status: Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

3 participants