Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Helm install fails because of invalid chars in labels when using flux OCI Repository #697

Closed
consooo opened this issue Jun 21, 2024 · 1 comment
Labels
kind/bug Something isn't working

Comments

@consooo
Copy link

consooo commented Jun 21, 2024

Describe the bug
Tested with Reloader v1.0.188 and flux v2.3.0. When using OCI Repository and HelmRelease with chartref as described here: https://fluxcd.io/blog/2024/05/flux-v2.3.0/#enhanced-helm-oci-support
flux adds the artifact digest to the chartversion in the format <version>+<digest[0:12]>
https://fluxcd.io/flux/components/helm/helmreleases/#chart-reference

reloader seems to use this version as a label on its service account, etc. The + is an invalid char in that case so the helm install fails.

To Reproduce
Store the Reloader Helmchart in an OCI Repository, and try to deploy it using flux v2.3.0 using

apiVersion: source.toolkit.fluxcd.io/v1beta2
kind: OCIRepository

Expected behavior
Reloader installs

Environment

  • Kubernetes/OpenShift Version: EKS 1.29
  • flux v2.3.0
  • reloader v1.0.188
@consooo consooo added the kind/bug Something isn't working label Jun 21, 2024
@consooo
Copy link
Author

consooo commented Jun 21, 2024

Sorry, will be fixed in -> #686

@consooo consooo closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant