Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics Status/Sort] Unit tests #189

Closed
3 tasks
elraphty opened this issue Dec 19, 2023 · 9 comments
Closed
3 tasks

[Metrics Status/Sort] Unit tests #189

elraphty opened this issue Dec 19, 2023 · 9 comments

Comments

@elraphty
Copy link
Collaborator

elraphty commented Dec 19, 2023

Create a unit test for the bounties listed on the SuperAdmin page for the following areas listed below:

I should be able to view the bounties by the sort direction selected.
I should be able to view the bounties by the status selected.
I should be able to view the bounties by the default sort direction selection "newest" DESC

Details

  • Create a mock API call for metrics/bounties, the mock data return should be sorted by descending order as default.
  • When the sort order is changed the bounties should be sorted according to that either by newest (DESC), or oldest (ASC)
  • When a status is selected Open/Paid/Assigned, only the tickets that match this status should be displayed

Use this PR as an example for testing Unit Test PR

This is the second half for the issue: stakwork/sphinx-tribes#1012

Acceptance criteria

  • Unit test for getBountiesByRange in main.ts
  • Run unit test with wrong data intentionally to see if it fails
  • Run unit tests with right data to see if it passes
@ecurrencyhodler
Copy link
Contributor

@kevkevinpal can you review this ticket to see if it's acceptable?

@ecurrencyhodler ecurrencyhodler transferred this issue from stakwork/sphinx-tribes Feb 7, 2024
@Ekep-Obasi
Copy link
Contributor

@ecurrencyhodler Could you please assign?

@ecurrencyhodler
Copy link
Contributor

Hey @Ekep-Obasi you have 4 open bounties. Do you have PR's for them? Would be great to close some of those out before giving you another bounty.

@Ekep-Obasi
Copy link
Contributor

@ecurrencyhodler, i have submitted PRs for 03 of them. Awaiting reviews

@ecurrencyhodler
Copy link
Contributor

I took a look and am going to leave this one open. Let's get you another bounty when one of those closes.

@Ekep-Obasi
Copy link
Contributor

@ecurrencyhodler alright, thank you

@AbdulWahab3181
Copy link
Contributor

@ecurrencyhodler could you please assign me?

@AbdulWahab3181
Copy link
Contributor

@elraphty @ecurrencyhodler It seems like the same issue was created here.

@ecurrencyhodler
Copy link
Contributor

Ah good catch. Sorry for the duplicate ticket. This was an old one that I unblocked recently so didn't realize it.

@ecurrencyhodler ecurrencyhodler closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants