Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement src-20 api balance image display into leather wallet #437

Open
reinamora137 opened this issue Dec 5, 2024 · 3 comments
Open

Comments

@reinamora137
Copy link
Contributor

Submit a PR into leather wallet to display SRC-20 images - when they pull from the /src20/balance endpoint there is a stamp_url image there that can be displayed in their wallet extension instead of the default purple background

https://github.com/leather-io/extension

they should be pulling from https://stampchain.io/api/v2/src20/balance/bc1qhhv6rmxvq5mj2fc3zne2gpjqduy45urapje64m

and https://stampchain.io/api/v2/stamps/balance/bc1qhhv6rmxvq5mj2fc3zne2gpjqduy45urapje64m or perhaps the /api/v2/balance endpoint. however i'm currently not seeing either stamps or src20 displaying in their wallet. Perhaps something got borked in the new api revisions?

@reinamora137
Copy link
Contributor Author

reinamora137 commented Dec 5, 2024

it appears there may be something broken on all stamps/src-20 tokens displaying as they are referencing the old asset.html? which should redirect to the newer /balance endpoint https://github.com/stampchain-io/BTCStampsExplorer/blob/dev/routes/%5B...path%5D.ts#L26

see:
https://github.com/search?q=org%3Aleather-io+stampchain&type=code

this all needs to be revised

there were some changes to the /api/v2/balance endpoint which it appears they are using. it would be more effective to use the /src20/balance and /stamps/balance separately to have more control of the pagination but either should be ok

@RisingStarDev
Copy link

the main conflict issue is coming from @leather.io/query npm package which was used in leather wallet extension
so, we need to update that npm package first

image
i found the code lines that cause the conflict error
we need to add .optional() for each field there
also, src20TokenSchema and stampTokenSchema need to be updated to match props from the updated endpoint
i've submitted issue to the git repo of @leather.io/query and you can find the submitted issue from the below link
leather-io/mono#719

@RisingStarDev
Copy link

i've submitted another issue for @leather.io/query and raised PR for leather wallet extension
leather-io/extension#6003
leather-io/mono#724
once they fix these issues on their side, i think src20 & stamp tokens display correctly on leather wallet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants