-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update internals to use more modern c++ #1308
Labels
Comments
This was referenced Aug 14, 2019
SteveBronder
changed the title
Use auto in multiply, subtract, and add prim functions
Update internals to use more modern c++
Aug 27, 2019
This was referenced Aug 27, 2019
Closed
This was referenced Sep 3, 2019
Merged
Closed
5 tasks
This was referenced Sep 30, 2019
5 tasks
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
As described in this discourse thread I think we can get away with using auto in the return types for simple functions like
add
,subtract
, andmultiply
.Example
Instead of a function signature such as
We now use
This is nice because
enable_if_all_eigen
checks that the template type inherits fromEigen::Base
, which means that Mat1 and Mat2 can be types likeEigen::Product<...>
orEigen::Diagonal<...>
Expected Output
Output should all stay the same
Current Version:
v2.20.0
The text was updated successfully, but these errors were encountered: