Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Bundler/DuplicatedGem #134

Closed
searls opened this issue Sep 3, 2019 · 2 comments
Closed

Disable Bundler/DuplicatedGem #134

searls opened this issue Sep 3, 2019 · 2 comments
Labels
approved 👍 rule change 👩‍⚖️ Suggest a style guide rule change

Comments

@searls
Copy link
Contributor

searls commented Sep 3, 2019

Bundler/DuplicatedGem will flag this:

if ENV["RAILS_NEXT"]
  gem "rails", "~> 5.1.0"
else
  gem "rails", "~> 5.0.0"
end

Which is in fact a very valid thing to do if you're upgrading rails by using bootboot. I think we should disable this one

@searls searls added approved 👍 rule change 👩‍⚖️ Suggest a style guide rule change labels Sep 3, 2019
@searls searls closed this as completed in 4cc0c77 Sep 3, 2019
@etagwerker
Copy link

@searls I ran into this issue this morning and I find it very weird because I was expecting v1.4.0 to have fixed it...

Sanity check over here:

Screen Shot 2021-11-15 at 10 34 30 AM

Gemfile over here:

Screen Shot 2021-11-15 at 10 30 08 AM

(source: https://github.com/fastruby/points/blob/main/Gemfile#L1-L23)

I see that 4cc0c77 was tagged with v1.4.0

But after doing bundle open standard in my local environment, this is what I see:

Screen Shot 2021-11-15 at 10 45 59 AM

@etagwerker
Copy link

I see that the false positive has been fixed in rubocop: rubocop/rubocop#8666 -- so this is probably a wrong version issue on my side...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved 👍 rule change 👩‍⚖️ Suggest a style guide rule change
Projects
None yet
Development

No branches or pull requests

2 participants