You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I feel strongly that the language models should derive Module or BaseModule. Like in PyTorch, everything (except for optimizers and other building blocks) derive Module.
I don't feel like LM should be treated as a special abstraction of it's own, rather, it should be a Module that implements a forward method that delegates to the abstract methods that need to be implemented by the deriving language models.
It should be a Module with a Signature (to be provided by the specific language modules), like any other module, which will enforce the PyTorch-style modular architecture of this framework. And again, the LM class, to me at least, does not seem like it needs to be a special abstraction of it's own, rather just another Module with a forward method implemented, and it's own abstract methods defined, one of which could be a method that returns the Signature of the language model.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I feel strongly that the language models should derive Module or BaseModule. Like in PyTorch, everything (except for optimizers and other building blocks) derive Module.
I don't feel like LM should be treated as a special abstraction of it's own, rather, it should be a Module that implements a forward method that delegates to the abstract methods that need to be implemented by the deriving language models.
It should be a Module with a Signature (to be provided by the specific language modules), like any other module, which will enforce the PyTorch-style modular architecture of this framework. And again, the LM class, to me at least, does not seem like it needs to be a special abstraction of it's own, rather just another Module with a forward method implemented, and it's own abstract methods defined, one of which could be a method that returns the Signature of the language model.
Please let me know your thoughts.
Beta Was this translation helpful? Give feedback.
All reactions