Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P0] Integration with FSDP #144

Open
xlxcomputer opened this issue Dec 13, 2024 · 1 comment
Open

[P0] Integration with FSDP #144

xlxcomputer opened this issue Dec 13, 2024 · 1 comment
Labels
engineering help wanted Extra attention is needed

Comments

@xlxcomputer
Copy link

I would like to ask if the reft and DeepSpeed methods are compatible. Because when I try to replace LoRA with DeepSpeed in the code, it throws an error as soon as I import the pyreft library.
@frankaging frankaging changed the title Can not work with deepspeed? [P1] Can not work with deepspeed? Dec 19, 2024
@frankaging
Copy link
Collaborator

@xlxcomputer Thanks for the q!

Working on it. It might still take some time, since we just support DDP (and currently finishing up another project): #143.

Next stop would be FSDP.

@frankaging frankaging changed the title [P1] Can not work with deepspeed? [P0] Integration with FSDP Dec 19, 2024
@frankaging frankaging pinned this issue Dec 19, 2024
@frankaging frankaging added the help wanted Extra attention is needed label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engineering help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frankaging @xlxcomputer