-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Freshness is not implemented #28
Comments
This should be solved pretty soon with the migration to v1.0.0 See 8df0f80 |
@wrborigin |
I tested it with dbt-trino 1.0, and it seems to have some problem. sources:
- name: redacted
database: redacted
schema: redacted
loaded_at_field: approval_date
Any idea what might be wrong? Even adding |
Please visit the trino web admin UI and paste the full stack trace of the problem. |
Trino UI shows a successful query of select
max(approval_date) as max_loaded_at,
CURRENT_TIMESTAMP as snapshotted_at
from "redacted"."redacted"."redacted" If I
so Trino definitely return timestamp. I remembered I was looking into this for dbt-presto sometime in summer, and the problem was that while Trino returns timestamp, the Python driver somehow makes it a string, and that's what dbt is complaning about. |
This is the stacktrace of the Printing the content of the table passed to
while the This seems to be a limitation of the The data coming back from Trino for the freshness request over HTTP looks like this:
Unfortunately it is not converted to the corresponding See https://github.com/trinodb/trino-python-client/blob/master/trino/client.py#L401 for details of the missing conversion logic. |
Related issue: |
Should be fixed by #61 as we use |
Resolved by #61 |
When I add source freshness configuration and run
dbt source freshness
with dbt-trino, I getThe text was updated successfully, but these errors were encountered: