Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use import instead of require for dependencies #160

Open
jmrog opened this issue Apr 11, 2018 · 0 comments
Open

Use import instead of require for dependencies #160

jmrog opened this issue Apr 11, 2018 · 0 comments
Assignees
Labels

Comments

@jmrog
Copy link
Contributor

jmrog commented Apr 11, 2018

Currently, we import using CommonJS syntax: const whatever = require('whatever');. This actually creates issues in some cases for consumers of stardog.js who also use webpack, since one of our transitive dependencies (node-fetch) uses ES modules, and webpack prefers ES modules when they're available, with the result that our require imports an object with a default property if stardog.js gets bundled by webpack (see this issue and especially this comment, as well as this issue. There are workarounds, but they're inconvenient, and there's probably no other compelling reason not to just use import anyway, so we should consider switching over for v2.

@jmrog jmrog added the v2 label Apr 11, 2018
@jmrog jmrog added this to the v2.0.0 milestone Apr 11, 2018
@sfkrauss sfkrauss modified the milestones: v2.0.0, Sprint Zucchini Apr 8, 2019
@sfkrauss sfkrauss modified the milestones: Sprint Zucchini, Sprint Elderberry Jun 3, 2019
@sfkrauss sfkrauss modified the milestones: Sprint Elderberry, Sprint Fig Jun 11, 2019
@sfkrauss sfkrauss modified the milestones: Sprint Fig, Sprint Guava Jun 27, 2019
@jmrog jmrog modified the milestones: Sprint Guava, Sprint Huckleberry Jul 9, 2019
@jmrog jmrog modified the milestones: Sprint Huckleberry, Sprint Imbe, Pre-Imbe Jul 23, 2019
@jmrog jmrog modified the milestones: Sprint Imbe, Sprint Jackfruit Aug 9, 2019
@jmrog jmrog modified the milestones: Sprint Jackfruit, Sprint Kiwi Aug 27, 2019
@jmrog jmrog modified the milestones: Sprint Kiwi, Sprint Lychee Sep 10, 2019
@jmrog jmrog modified the milestones: Sprint Lychee, Sprint Mango Sep 24, 2019
@jmrog jmrog removed this from the Sprint Mango milestone Oct 8, 2019
@jmrog jmrog added this to the Sprint Nectarine milestone Oct 8, 2019
@jmrog jmrog modified the milestones: Sprint Nectarine, Sprint Orange Oct 22, 2019
@jmrog jmrog modified the milestones: Sprint Orange, Sprint Pomegranate Nov 12, 2019
@jmrog jmrog modified the milestones: Sprint Pomegranate, Sprint Quince Dec 2, 2019
@jmrog jmrog removed this from the Sprint Quince milestone Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants