Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Include markdown in docker image #5174

Closed
Jakan-Kink opened this issue Aug 27, 2024 · 4 comments
Closed

[Feature] Include markdown in docker image #5174

Jakan-Kink opened this issue Aug 27, 2024 · 4 comments

Comments

@Jakan-Kink
Copy link

Is your feature request related to a problem? Please describe.
As part of a feature request we worked on in Fanscrape we added markdown handling to clean the titles. However the way we implemented it requires the python module markdown.

Describe the solution you'd like
Add the python module markdown to the docker image, so that way users don’t need to go into the docker container and add it manually every release.

Describe alternatives you've considered
As mentioned in solution, the user could install markdown manually but that gets cumbersome each stash update.

@DogmaDragon
Copy link
Collaborator

There are no plans to add any new modules to the official Docker image. There is a project #4300 to overhaul the current image to move module installation to the entry scripts, as just increasing the image size is not practical and far from ideal.

@feederbox826
Copy link
Contributor

override your pip install directory, and it will persist

@feederbox826
Copy link
Contributor

also why not just regex for ** instead of addng an entire library?

@Jakan-Kink
Copy link
Author

Yea, I’ll just update the readme to point to the venv / python path instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants