Skip to content

Commit

Permalink
Use Go 1.23 (#222)
Browse files Browse the repository at this point in the history
/cherry-pick

Signed-off-by: 1gtm <1gtm@appscode.com>
Signed-off-by: Tamal Saha <tamal@appscode.com>
  • Loading branch information
1gtm committed Aug 17, 2024
1 parent be71027 commit 36516c2
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
name: Build
runs-on: ubuntu-22.04
steps:
- name: Set up Go 1.22
- name: Set up Go 1.23
uses: actions/setup-go@v2
with:
go-version: '1.22'
go-version: '1.23'
id: go

- name: Check out code into the Go module directory
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
- name: Check out code into the Go module directory
uses: actions/checkout@v1

- name: Set up Go 1.22
- name: Set up Go 1.23
uses: actions/setup-go@v2
with:
go-version: '1.22'
go-version: '1.23'
id: go

- name: Print version info
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/update-crds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
name: Build
runs-on: ubuntu-22.04
steps:
- name: Set up Go 1.22
- name: Set up Go 1.23
uses: actions/setup-go@v2
with:
go-version: '1.22'
go-version: '1.23'
id: go

- uses: actions/checkout@v1
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ ARCH := $(if $(GOARCH),$(GOARCH),$(shell go env GOARCH))
BASEIMAGE_PROD ?= gcr.io/distroless/static-debian12
BASEIMAGE_DBG ?= debian:bookworm

GO_VERSION ?= 1.22
GO_VERSION ?= 1.23
BUILD_IMAGE ?= ghcr.io/appscode/golang-dev:$(GO_VERSION)
TEST_IMAGE ?= ghcr.io/appscode/golang-dev:$(GO_VERSION)-stash

Expand Down
3 changes: 2 additions & 1 deletion pkg/util/backup.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package util

import (
"context"
"errors"
"fmt"
"time"

Expand Down Expand Up @@ -91,7 +92,7 @@ func IsRepositoryInitialized(opt ActionOptions) (bool, error) {
// If the condition is present but it is set to "False", then the repository initialization has failed. Possibly due to invalid backend / storage secret.
if !cutil.IsConditionTrue(backupSession.Status.Conditions, v1beta1.BackendRepositoryInitialized) {
_, cnd := cutil.GetCondition(backupSession.Status.Conditions, v1beta1.BackendRepositoryInitialized)
return false, fmt.Errorf(cnd.Reason)
return false, errors.New(cnd.Reason)
}
return true, nil
}
Expand Down

0 comments on commit 36516c2

Please sign in to comment.