Show scheme in endpoint for Minio Repository (#118)

Signed-off-by: Emruz Hossain <emruz@appscode.com> Fixes stashed/stash#1280
stashed · Dec 17, 2020 · 3ba0722 · 3ba0722
1 parent 7aa0987
commit 3ba0722
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/docs/examples/guides/latest/backends/minio.yaml b/docs/examples/guides/latest/backends/minio.yaml
@@ -0,0 +1,12 @@
+apiVersion: stash.appscode.com/v1alpha1
+kind: Repository
+metadata:
+  name: minio-repo
+  namespace: demo
+spec:
+  backend:
+    s3:
+      endpoint: https://my-minio-service.minio-namespace.svc
+      bucket: stash-demo
+      prefix: /backup/demo/deployment/stash-demo
+    storageSecretName: minio-secret
diff --git a/docs/examples/guides/latest/backends/s3.yaml b/docs/examples/guides/latest/backends/s3.yaml
@@ -8,5 +8,6 @@ spec:
     s3:
       endpoint: s3.amazonaws.com # use server URL for s3 compatible other storage service
       bucket: stash-demo
+      region: us-west-1
       prefix: /backup/demo/deployment/stash-demo
     storageSecretName: s3-secret
diff --git a/docs/guides/latest/backends/s3.md b/docs/guides/latest/backends/s3.md
@@ -90,7 +90,24 @@ spec:
     storageSecretName: s3-secret
 ```
 
-Create the `Repository` we have shown above using the following command,
+For S3 compatible Minio and other storage services, specify the endpoint with connection scheme (`http`, or `https`),
+
+```yaml
+apiVersion: stash.appscode.com/v1alpha1
+kind: Repository
+metadata:
+  name: minio-repo
+  namespace: demo
+spec:
+  backend:
+    s3:
+      endpoint: https://my-minio-service.minio-namespace.svc
+      bucket: stash-demo
+      prefix: /backup/demo/deployment/stash-demo
+    storageSecretName: s3-secret
+```
+
+Create the `s3-repo` Repository we have shown above using the following command,
 
 ```bash
 $ kubectl apply -f https://github.com/stashed/docs/raw/{{< param "info.version" >}}/docs/examples/guides/latest/backends/s3.yaml