Use BackoffLimit=0 for backup/restore job (#1216)

Signed-off-by: Emruz Hossain <emruz@appscode.com> Fixes #1216
stashed · Oct 21, 2020 · 40a233c · 40a233c
1 parent a206a9c
commit 40a233c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pkg/controller/backup_session.go b/pkg/controller/backup_session.go
@@ -381,7 +381,7 @@ func (c *StashController) ensureBackupJob(invoker apis.Invoker, targetInfo apis.
 			in.Spec.Template.Spec = podSpec
 			in.Spec.Template.Spec.ImagePullSecrets = imagePullSecrets
 			in.Spec.Template.Spec.ServiceAccountName = serviceAccountName
-			in.Spec.BackoffLimit = types.Int32P(1)
+			in.Spec.BackoffLimit = types.Int32P(0)
 			return in
 		},
 		metav1.PatchOptions{},
@@ -466,7 +466,7 @@ func (c *StashController) ensureVolumeSnapshotterJob(invoker apis.Invoker, targe
 			in.Spec.Template.Spec.ImagePullSecrets = imagePullSecrets
 			in.Spec.Template.Spec.ServiceAccountName = serviceAccountName
 
-			in.Spec.BackoffLimit = types.Int32P(1)
+			in.Spec.BackoffLimit = types.Int32P(0)
 			return in
 		},
 		metav1.PatchOptions{},

diff --git a/pkg/controller/restore_session.go b/pkg/controller/restore_session.go
@@ -635,7 +635,7 @@ func (c *StashController) createRestoreJob(jobTemplate *core.PodTemplateSpec, me
 			core_util.EnsureOwnerReference(&in.ObjectMeta, owner)
 
 			in.Spec.Template = *jobTemplate
-			in.Spec.BackoffLimit = types.Int32P(1)
+			in.Spec.BackoffLimit = types.Int32P(0)
 			return in
 		},
 		metav1.PatchOptions{},
@@ -803,7 +803,7 @@ func (c *StashController) ensureVolumeRestorerJob(invoker apis.RestoreInvoker, i
 			in.Spec.Template = *jobTemplate
 			in.Spec.Template.Spec.ImagePullSecrets = imagePullSecrets
 			in.Spec.Template.Spec.ServiceAccountName = serviceAccountName
-			in.Spec.BackoffLimit = types.Int32P(1)
+			in.Spec.BackoffLimit = types.Int32P(0)
 			return in
 		},
 		metav1.PatchOptions{},