-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focal point not saved when blueprint has no fields #2954
Comments
Seems to be working fine for me. I removed all the fields from my asset container's blueprint so it was left looking like this: sections:
main:
display: Main
fields: { } I then opened up one of my asset's meta yaml files in my code editor, and removed its contents. Then I went into the Asset library, set a focal point and saved my changes. I then confirmed that there was data set inside the asset's meta yaml file, including the focal point. The focal point also changed fine for me when I updated it. |
I am not sure about you guys, but I just experienced that issue again and it bugs me a lot... Statamic 3.2.17 Pro Asset blueprint has no fields and the meta file of the asset looks like this:
When I then try to update the focal point, its not saved to the file! Annoying! |
Can you provide a repo with this problem reproduced? |
@jasonvarga I just reproduced this issue in a fresh install. so really nothing special configured. but anyways I created a repo: https://github.com/marcusand/statamic-focal-point-issue |
I can recreate it if i don't save any asset meta data before removing the |
Was able to just reproduce it on a fresh 3.3.14 via CLI. |
I looked into this and just wanted to let you know that I have found a fix for this and will open a PR at start of October for Hacktoberfest. Just in case anyone else planned to pick up this issue. |
Bug Description
When setting a focal point on an image which is connected to an empty blueprint, the focal point is not saved.
How to Reproduce
Environment
Statamic 3.0.31 Pro
Laravel 7.29.3
PHP 7.3.24
statamic/migrator dev-master
Install method (choose one):
statamic/statamic
The text was updated successfully, but these errors were encountered: