-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize taxonomy <> collection queries #376
Optimize taxonomy <> collection queries #376
Conversation
@TheBnl let's move the conversation over here. I've modified the approach and have tests working on SQLite and it works fine on MySQL from my own testing. Do you have access to sqlserver or postgres to check this on? It also needs some test coverage if you could work on that. |
Awesome! Will test on postgress, haven't came by to installing sqlserver yet. Will check and look into adding postgress/sqlserver to the github test workflow. 👍 |
Tested with postgres and there we do need wrap it so the value will be handled as json: Working on the test coverage in a different branch, also to test sqlserver, as it is quite a bit of work of settings things up right. |
Sorry I didn't mean we need to set up different testing environments for each database engine - I just meant we needed a test in the suite to cover this new behaviour. |
Ah haha well that makes things quite simpler. I've added a test where the entries driver is set to 'file' so both the join and map gets tested. |
Thanks for your work on this - really appreciate it. |
Awesome thanks for merging! |
Working on a draft to fix issue #373
The current implementation does not yet pass the tests due to not being fully db driver independent.
The test fails because
JSON_QUOTE
seems to behave different in sqllite than mysql.The
JSON_QUOTE
should probably not be hard coded here as well because we can't assume the db driver that is in use.Closes #373