From 569ccbc63cffc6575e1ca417e1998912ca8f5695 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Burzy=C5=84ski?= <mateuszburzynski@gmail.com>
Date: Thu, 7 Mar 2024 15:24:46 +0100
Subject: [PATCH] Add extra tests for adding a state

---
 .../__tests__/source-edits/add-state.test.ts  | 133 ++++++++++++++++++
 1 file changed, 133 insertions(+)

diff --git a/new-packages/ts-project/__tests__/source-edits/add-state.test.ts b/new-packages/ts-project/__tests__/source-edits/add-state.test.ts
index ebbbf5b2..683bfc60 100644
--- a/new-packages/ts-project/__tests__/source-edits/add-state.test.ts
+++ b/new-packages/ts-project/__tests__/source-edits/add-state.test.ts
@@ -2,6 +2,56 @@ import { outdent } from 'outdent';
 import { expect, test } from 'vitest';
 import { createTestProject, testdir, ts } from '../utils';
 
+test(`should append a state after existing states of a nested state`, async () => {
+  const tmpPath = await testdir({
+    'tsconfig.json': JSON.stringify({}),
+    'index.ts': ts`
+      import { createMachine } from "xstate";
+
+      createMachine({
+        states: {
+          foo: {
+            states: {
+              bar: {},
+            },
+          },
+        },
+      });
+    `,
+  });
+
+  const project = await createTestProject(tmpPath);
+
+  const textEdits = project.editDigraph(
+    {
+      fileName: 'index.ts',
+      machineIndex: 0,
+    },
+
+    {
+      type: 'add_state',
+      path: ['foo'],
+      name: 'just_added',
+    },
+  );
+  expect(await project.applyTextEdits(textEdits)).toMatchInlineSnapshot(`
+    {
+      "index.ts": "import { createMachine } from "xstate";
+
+    createMachine({
+      states: {
+        foo: {
+          states: {
+            bar: {},
+            just_added: {},
+          },
+        },
+      },
+    });",
+    }
+  `);
+});
+
 test('should append a state after existing states (with trailing comma)', async () => {
   const tmpPath = await testdir({
     'tsconfig.json': JSON.stringify({}),
@@ -617,6 +667,43 @@ test('should successfully add a state to the root and use it as initial state of
   );
 });
 
+// this shouldn't be possible in the Studio but we handle this here regardless
+test('should be possible to add a state to the empty root (without making it its initial state)', async () => {
+  const tmpPath = await testdir({
+    'tsconfig.json': JSON.stringify({}),
+    'index.ts': ts`
+      import { createMachine } from "xstate";
+
+      createMachine({});
+    `,
+  });
+
+  const project = await createTestProject(tmpPath);
+
+  const textEdits = project.editDigraph(
+    {
+      fileName: 'index.ts',
+      machineIndex: 0,
+    },
+    {
+      type: 'add_state',
+      path: [],
+      name: 'just_added',
+    },
+  );
+  expect(await project.applyTextEdits(textEdits)).toMatchInlineSnapshot(`
+    {
+      "index.ts": "import { createMachine } from "xstate";
+
+    createMachine({
+    	states: {
+    		just_added: {}
+    	}
+    });",
+    }
+  `);
+});
+
 test('should successfully add a state to a nested state and use it as initial state of its parent', async () => {
   const tmpPath = await testdir({
     'tsconfig.json': JSON.stringify({}),
@@ -712,3 +799,49 @@ test(`should be possible to add a state with name that isn't a valid identifier`
   `,
   );
 });
+
+test(`should be possible to add a state to an empty nested state`, async () => {
+  const tmpPath = await testdir({
+    'tsconfig.json': JSON.stringify({}),
+    'index.ts': ts`
+      import { createMachine } from "xstate";
+
+      createMachine({
+        states: {
+          foo: {},
+        },
+      });
+    `,
+  });
+
+  const project = await createTestProject(tmpPath);
+
+  const textEdits = project.editDigraph(
+    {
+      fileName: 'index.ts',
+      machineIndex: 0,
+    },
+    [
+      {
+        type: 'add_state',
+        path: ['foo'],
+        name: 'just_added',
+      },
+    ],
+  );
+  expect(await project.applyTextEdits(textEdits)).toMatchInlineSnapshot(`
+    {
+      "index.ts": "import { createMachine } from "xstate";
+
+    createMachine({
+      states: {
+        foo: {
+          states: {
+            just_added: {}
+          }
+        },
+      },
+    });",
+    }
+  `);
+});