Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of service container AddPipeline extensions #239

Open
daveaglick opened this issue Jun 8, 2022 · 0 comments
Open

Change name of service container AddPipeline extensions #239

daveaglick opened this issue Jun 8, 2022 · 0 comments
Labels
General Enhancement New feature or request

Comments

@daveaglick
Copy link
Member

Some of the AddPipeline extensions register the pipeline class with the DI container which can be confusing ordering-wise. They should be renamed to RegisterPipeline or similar with appropriate code documentation explaining the difference. But because we don't want to outright break anyone given how common these methods are, the old ones shouldn't be removed but marked with ObsoleteAttribute and forward to the new ones instead.

@daveaglick daveaglick added the General Enhancement New feature or request label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Enhancement New feature or request
Development

No branches or pull requests

1 participant