Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime support for Ethereum network configuration #2387

Open
kdeme opened this issue Jun 18, 2024 · 2 comments
Open

Add runtime support for Ethereum network configuration #2387

kdeme opened this issue Jun 18, 2024 · 2 comments
Labels

Comments

@kdeme
Copy link
Contributor

kdeme commented Jun 18, 2024

Support for Portal testnets got added here: #2206

However, once different data than the mainnet data gets used on a Portal network, the node will also need to be able to select which network config to use per network.

@kdeme kdeme added the Fluffy label Jun 18, 2024
@bhartnett
Copy link
Contributor

bhartnett commented Jun 21, 2024

I guess this config selection should be based on the selected --network so selecting a network that contains non-mainnet data would trigger reading in the matching config.

One thing to think about is how should Fluffy handle local networks when selecting --network=none. Currently we default to using mainnet config but what if you want to test different data in a private network.

@kdeme
Copy link
Contributor Author

kdeme commented Jun 21, 2024

One thing to think about is how should Fluffy handle local networks when selecting --network=none. Currently we default to using mainnet config but what if you want to test different data in a private network.

Yes, we don't have thought this through currently. In the case of network none we need extra way to say which config.

Perhaps we add an additional --network-config flag specifically for this setup.
Or additional info can get added in the network flag, e.g. --network=none:mainnet or something like that. We could also rename none to custom or similar. Open to ideas here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants