Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add ENS domain name as a saved address #13381

Closed
benjthayer opened this issue Feb 1, 2024 · 2 comments · Fixed by #13815
Closed

Ability to add ENS domain name as a saved address #13381

benjthayer opened this issue Feb 1, 2024 · 2 comments · Fixed by #13815

Comments

@benjthayer
Copy link

benjthayer commented Feb 1, 2024

Creating saved address flows updated to include the case of adding an ENS domain as a saved address.

The user should be able to enter an ENS domain into the Address field. The resolver service should ensure the appropriate address is used for the ENS at the point of interaction (e.g. sending tokens to the ENS domain).

When the Address field detects a valid ENS domain, the network preferences section is hidden as it is not applicable/relevant for ENS domain names. When this happens, the dialog should collapse in height to remove the empty space that would be left by the missing section.

Screenshot 2024-02-01 at 6 00 10 PM

Figma
https://www.figma.com/file/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?type=design&node-id=23256-263282&mode=design&t=0DRwQJKDGYJPHkq1-4

@alaibe
Copy link
Collaborator

alaibe commented Feb 9, 2024

@benjthayer are you sure you want jumping button? it may look a bit weird to see element taking other position

@benjthayer
Copy link
Author

@benjthayer are you sure you want jumping button? it may look a bit weird to see element taking other position

Hey @alaibe ideally, the network preferences would quickly fade out and the dialog would perform an animated transition into it's smaller state - if we can achieve this subtle motion, I don't think the jump in the dialog resulting from the hiding of the network preferences should be too disorienting. Is something like that possible? The overall transition should be under 1 sec and the reverse transition should happen if the eth address is replaced with an ethereum address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment