Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clicking several times on the "Connect" button on the Connection request screen while being offline causes strange behavior when app is back online #15636

Open
Tracked by #16312
virginiabalducci opened this issue Jul 17, 2024 · 0 comments
Labels
Milestone

Comments

@virginiabalducci
Copy link

Bug Report

Description

clicking several times on the "Connect" button on the Connection request screen while being offline causes strange behavior when app is back online.
While being offline, "Connect" button is clickable, but when clicked shows no response to the user. It seems that all the times the user clicks the Connect button are accumulated and when connection is re-established, all these clicks are sent.

I didn't add this to the 2.30 Milestone because in my opinion this is not very likely to happen but please set the milestone and priority as you consider. Thanks!

Steps to reproduce

  1. Copy the wallet connect link of a dApp, for example https://app.compound.finance/
  2. Go to Status app -> Wallet -> click on the wallet connect icon and copy the URI link
  3. On the Connection request screen, disconnect the internet
  4. Clicking on "Connect" button does nothing. Click it many times.
  5. Re-establish the internet connection
  6. "dApp connected" screen shows, indicating dApp has connected by itself without letting user confirm that they indeed want to connect once internet has been established
  7. Many notifications of the same message display "Connected to app.compound.finance via WalletConnect" probably this is related to the number of times the Connect button was clicked while being offline?
Screenshot 2024-07-17 at 10 16 34 AM
  1. Still on the pop up, select "Disconnect"
  2. Go to the dApp icon and notice that Compound dApp shows in the list as connected
  3. Go to the Compound site and reload. Notice that the balance of the wallet is not updated.
  4. Go to Status app and disconnect the Compound dApp.
  5. Many notifications of this disconnection trigger.
Screenshot 2024-07-17 at 10 26 41 AM

Expected behavior

For step 6, it would be nice to have a message letting the user know that there is no internet connection to proceed with the action, or to disable the action buttons.
For step 5, when internet connection is re-established, the dApp has been connected without a confirmation from the user while being online. It also shows the "Disconnect" button, which, when selected, triggers many notifications but this action does not seem to disconnect the dApp.

Actual behavior

Screen.Recording.2024-07-17.at.10.05.30.AM.no.internet.disconnect.dapp.mov

Additional Information

As additional information, I'm attaching screen recordings of same steps clicking different number of times:

While offline, user clicks "Connect" 1 time
https://github.com/user-attachments/assets/81eaeeb2-2918-468c-88bf-02d592ed16dc

While offline, user does nothing
https://github.com/user-attachments/assets/7ace6c5a-571e-491a-854c-63b93ca602c3

User clicking "Connect" 3 times while offline
https://github.com/user-attachments/assets/8a3fdc1e-2639-4559-b631-20e8ed8481b9

  • Status desktop version: master 26508f5c9
  • Operating System: Mac OS Sonoma
@virginiabalducci virginiabalducci added bug Something isn't working dapp-interactions labels Jul 17, 2024
@anastasiyaig anastasiyaig added this to the 2.30.0 Beta milestone Jul 25, 2024
@jrainville jrainville modified the milestones: 2.30.0 Beta, 2.31.0 Beta Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

4 participants