Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApps - Zapper.fi transactions can be sign approved but cannot be completed #16004

Open
Tracked by #16312
virginiabalducci opened this issue Aug 6, 2024 · 5 comments
Assignees
Labels
Milestone

Comments

@virginiabalducci
Copy link

Bug Report

Description

When the Status wallet account is connected to Zapper.xyz via Wallet Connect, and user wants to perform a transaction (Bridge or Swap), the transaction can be sign approved but cannot be completed.

Steps to reproduce

  1. Log in with an account who has enough funds to try transactions
  2. Go to https://zapper.xyz/ and connect the Status wallet via Wallet Connect
  3. Start a swap or bridge transaction
  4. Sign the "sign request" pop up on Status app
  5. On Zapper, see that nothing happens. The transaction does not complete.

Expected behavior

After the sign request on Status app, user should be able to confirm and perform the transaction

Actual behavior

After the sign request on Status app has been approved, nothing happens on the dApp's side, as if the Sign authorization request from Status app never reached the Zapper server.
Also worth mentioning that while I was trying to do a transaction, the activity list history was deleted. This account has plenty of activity, including a successful transaction on Aave Finance (deposit and withdraw)

Screen.Recording.2024-08-06.at.4.17.23.PM.zapper.activity.mov
Screen.Recording.2024-08-06.at.4.35.35.PM.mov

Bridge test
https://github.com/user-attachments/assets/86264032-b252-421e-acad-4e5f2a7ea8b9

Swap test
https://drive.google.com/file/d/12UFoaMnqJixfOAbz_XO6axRXd1oZdPIz/view?usp=sharing
https://drive.google.com/file/d/1MQctij9Ldp-55siev4irlvYHbV2CagPJ/view?usp=sharing

Wallet address: 0x32e12fd7c2c7984dd6de153691d901445fc8aa07

Console error
console log zapper.txt

ERR 2024-08-06 16:33:55.086-03:00 qt error                                   topics="qt" tid=536262 text=">Error finding event for topic 01f4dfa567545130f8b4659b9efe2724c09bf0e2d09aa7a9480da3a166243ec9 id 1722972827851972" file=qrc:/app/AppLayouts/Wallet/services/dapps/DappsConnectorSDK.qml:296 category=qml
DBG 2024-08-06 16:33:55.483-03:00 qt message                                 topics="qt" tid=536262 text="WC WalletConnectSDK.onAcceptSessionRequestResponse; topic: 01f4dfa567545130f8b4659b9efe2724c09bf0e2d09aa7a9480da3a166243ec9, id: 1722972827851972 error: " file=qrc:/app/AppLayouts/Wallet/services/dapps/WalletConnectSDK.qml:398 category=qml
DBG 2024-08-06 16:33:55.484-03:00 qt message                                 topics="qt" tid=536262 text="WC WalletConnectSDK.wcCall.getActiveSessions;" file=qrc:/app/AppLayouts/Wallet/services/dapps/WalletConnectSDK.qml:127 category=qml

Additional Information

  • Status desktop version: 2.30 rc-4
  • Operating System: Mac OS Sonoma
@virginiabalducci virginiabalducci added bug Something isn't working dapp-interactions labels Aug 6, 2024
@virginiabalducci virginiabalducci added this to the 2.30.0 Beta milestone Aug 6, 2024
@anastasiyaig
Copy link
Contributor

i guess it is 2.31 as dapps are not for 2.30 anymore

@anastasiyaig anastasiyaig modified the milestones: 2.30.0 Beta, 2.31.0 Beta Aug 16, 2024
@virginiabalducci
Copy link
Author

This issue looks like it's still reproducible

Screen.Recording.2024-09-09.at.5.49.09.PM.mov

app_20240909_174237.log

DBG 2024-09-09 17:50:25.948-03:00 qt message                                 topics="qt" tid=27806550 text="WC unhandled event: \"relayer_disconnect\" connection to the relay server is lost" file=qrc:/app/AppLayouts/Wallet/services/dapps/WalletConnectSDK.qml:277 category=qml
DBG 2024-09-09 17:50:26.482-03:00 NewBE_callPrivateRPC                       topics="rpc" tid=27806550 file=core.nim:27 rpc_method=wakuext_markAsSeenActivityCenterNotifications
DBG 2024-09-09 17:50:27.516-03:00 qt message                                 topics="qt" tid=27806550 text="WC unhandled event: \"relayer_connect\" connection to the relay server is established" file=qrc:/app/AppLayouts/Wallet/services/dapps/WalletConnectSDK.qml:277 category=qml
WRN 2024-09-09 17:50:27.723-03:00 qt warning                                 topics="qt" tid=27806550 text="error parsing saved address for address:  0x8276724b7ebc11abc91fe5bcdde0be04972b34d0  error:  JSON.parse: Parse error" file=qrc:/app/AppLayouts/Wallet/stores/RootStore.qml:300 category=qml
DBG 2024-09-09 17:50:27.744-03:00 NewBE_callPrivateRPC                       topics="rpc" tid=27806550 file=core.nim:27 rpc_method=wallet_getActivityCollectiblesAsync
DBG 2024-09-09 17:50:27.745-03:00 NewBE_callPrivateRPC                       topics="rpc" tid=27806550 file=core.nim:27 rpc_method=wallet_getRecipientsAsync
WRN 2024-09-09 17:50:27.773-03:00 qt warning                                 topics="qt" tid=27806550 text="error parsing saved address for address:  0x0b2c639c533813f4aa9d7837caf62653d097ff85  error:  JSON.parse: Parse error" file=qrc:/app/AppLayouts/Wallet/stores/RootStore.qml:300 category=qml
WRN 2024-09-09 17:50:27.781-03:00 qt warning                                 topics="qt" tid=27806550 text="error parsing saved address for address:  0x0000000000000068f116a894984e2db1123eb395  error:  JSON.parse: Parse error" file=qrc:/app/AppLayouts/Wallet/stores/RootStore.qml:300 category=qml
WRN 2024-09-09 17:50:27.788-03:00 qt warning                                 topics="qt" tid=27806550 text="error parsing saved address for address:  0x64613f6b96cbfa4a110604744dd7af5f43b6b253  error:  JSON.parse: Parse error" file=qrc:/app/AppLayouts/Wallet/stores/RootStore.qml:300 category=qml
WRN 2024-09-09 17:50:27.795-03:00 qt warning                                 topics="qt" tid=27806550 text="error parsing saved address for address:  0x0000000000000068f116a894984e2db1123eb395  error:  JSON.parse: Parse error" file=qrc:/app/AppLayouts/Wallet/stores/RootStore.qml:300 category=qml
WRN 2024-09-09 17:50:27.816-03:00 qt warning                                 topics="qt" tid=27806550 text="error parsing saved address for address:  0xa99e061254b68cecdc78ad49a3a5869780dce6c1  error:  JSON.parse: Parse error" file=qrc:/app/AppLayouts/Wallet/stores/RootStore.qml:300 category=qml

@saledjenic
Copy link
Contributor

I've just tested this and it worked fine on my side:

@virginiabalducci could you try it again in the latest master?

@virginiabalducci
Copy link
Author

I was able to do a swap on Zapper
Arbitrum tx hash
https://arbiscan.io/tx/0x9b0b53f2979a0a92e20cf930170d1536ae88871ae3ba0a237c2314659e236ecf
0x9b0b53f2979a0a92e20cf930170d1536ae88871ae3ba0a237c2314659e236ecf

Bridge L2 to L2 (Arbitrum to Optimism): ✅
0x131ec7ee0f84fa36ef46651687bef0b387da99468ad62c5f03fa2f30ae6a5811
https://optimistic.etherscan.io/tx/0x131ec7ee0f84fa36ef46651687bef0b387da99468ad62c5f03fa2f30ae6a5811

I can't bridge L1 to L2, but I'm getting a block from the dApp's page itself and not from the desktop app: ⚠️

https://github.com/user-attachments/assets/3b0e4942-5640-4eed-8140-f30923c0d821
app_20240923_151252.log
app_20240923_160359.log
I'm attaching the last two console logs from the desktop app in case this helps.

I was able to do a Swap transaction and L2 - L2 bridge

@saledjenic

@alexjba
Copy link
Contributor

alexjba commented Sep 27, 2024

I can't bridge L1 to L2, but I'm getting a block from the dApp's page itself and not from the desktop app

@virginiabalducci Does it work on other dApps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

5 participants