Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of HoldingsSelectionModel #16407

Open
micieslak opened this issue Sep 25, 2024 · 1 comment
Open

Get rid of HoldingsSelectionModel #16407

micieslak opened this issue Sep 25, 2024 · 1 comment
Labels

Comments

@micieslak
Copy link
Member

Description

HoldingsSelectionModel is adaptor-like component from times when the only proxy model available was SFPM. It combines models by doing lookup in expression roles to another models. This mechanism is inefficient and problematic also from pov code structure - data cannot be prepared early in the flow, multiple models must be passed to views and combined already in the view.

It's necessary to review usages HoldingsSelectionModel and build efficient adaptor, how we do it nowadays. Probably also some views can be improved then regarding their API and compliance with the guideline.

@micieslak
Copy link
Member Author

Related PR: #16363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant